Skip to content

Commit 84625f3

Browse files
committed
[NFC] Improve test comments
1 parent 5802d21 commit 84625f3

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

test/NameLookup/module_selector.swift

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ extension ModuleSelectorTestingKit::A: @retroactive Swift::Equatable {
3636
mutating func myNegate() {
3737
let fn: (Swift::Int, Swift::Int) -> Swift::Int =
3838
(+)
39-
// FIXME: it'd be nice to handle module selectors on operators.
39+
// TODO: it'd be nice to handle module selectors on operators.
4040

4141
let magnitude: Int.Swift::Magnitude = main::magnitude
4242
// expected-error@-1 {{cannot convert value of type 'Never' to specified type 'Int.Magnitude' (aka 'UInt')}}
@@ -91,7 +91,7 @@ extension B: main::Equatable {
9191
// expected-note@-3 {{did you mean module 'Swift'?}} {{25-29=Swift}}
9292
// expected-note@-4 {{did you mean module 'Swift'?}} {{39-43=Swift}}
9393
(main::+)
94-
// FIXME: it'd be nice to handle module selectors on operators.
94+
// TODO: it'd be nice to handle module selectors on operators.
9595
// expected-error@-2 {{expected expression}}
9696
// expected-error@-3 {{expected expression after operator}}
9797

@@ -154,7 +154,7 @@ extension ModuleSelectorTestingKit::C: ModuleSelectorTestingKit::Equatable {
154154
// expected-note@-3 {{did you mean module 'Swift'?}} {{45-69=Swift}}
155155
// expected-note@-4 {{did you mean module 'Swift'?}} {{79-103=Swift}}
156156
(ModuleSelectorTestingKit::+)
157-
// FIXME: it'd be nice to handle module selectors on operators.
157+
// TODO: it'd be nice to handle module selectors on operators.
158158
// expected-error@-2 {{expected expression}}
159159
// expected-error@-3 {{expected expression after operator}}
160160

@@ -211,11 +211,11 @@ extension D: @retroactive Swift::Equatable {
211211
// FIXME improve: expected-note@-1 {{did you mean 'myNegate'?}}
212212

213213
let fn: (Swift::Int, Swift::Int) -> Swift::Int =
214-
// FIXME:
215214
(Swift::+)
216-
// expected-error@-1 {{cannot convert value of type '()' to specified type '(Int, Int) -> Int'}}
217-
// expected-error@-2 {{expected expression}}
218-
// expected-error@-3 {{expected expression after operator}}
215+
// TODO: it'd be nice to handle module selectors on operators.
216+
// expected-error@-2 {{cannot convert value of type '()' to specified type '(Int, Int) -> Int'}}
217+
// expected-error@-3 {{expected expression}}
218+
// expected-error@-4 {{expected expression after operator}}
219219
let magnitude: Int.Swift::Magnitude = Swift::magnitude
220220
// expected-error@-1 {{declaration 'magnitude' is not imported through module 'Swift'}}
221221
// FIXME should be un-addressable via main: expected-note@-2 {{did you mean module 'main'?}}
@@ -254,7 +254,7 @@ struct AvailableUser {
254254
}
255255

256256
func builderUser2(@main::MyBuilder fn: () -> Void) {}
257-
// FIXME improve: expected-error@-1 {{unknown attribute 'MyBuilder'}}
257+
// FIXME should succeed: expected-error@-1 {{unknown attribute 'MyBuilder'}}
258258

259259
func builderUser3(@ModuleSelectorTestingKit::MyBuilder fn: () -> Void) {}
260260
// no-error
@@ -464,6 +464,7 @@ func badModuleNames() {
464464

465465
_ = "foo".NonexistentModule::count
466466
// FIXME improve: expected-error@-1 {{value of type 'String' has no member 'NonexistentModule::count'}}
467+
// FIXME: expected-EVENTUALLY-note@-2 {{did you mean module 'Swift'?}} {{13-30=Swift}}
467468

468469
let x: NonexistentModule::MyType = NonexistentModule::MyType()
469470
// expected-error@-1 {{cannot find type 'NonexistentModule::MyType' in scope}}

0 commit comments

Comments
 (0)