Skip to content

Commit 86f37e2

Browse files
committed
SIL: Fill in unimplemented logic in verifyDynamicPackIndexStructuralEquality()
However, it should probably do something more elaborate where it recovers the conformance from the pack conformance instead.
1 parent 80f8487 commit 86f37e2

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

lib/SIL/Verifier/SILVerifier.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5719,10 +5719,9 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
57195719
auto substConformances = [&](CanType dependentType,
57205720
Type conformingType,
57215721
ProtocolDecl *protocol) -> ProtocolConformanceRef {
5722-
// FIXME: substitute back to the pack context to get the
5723-
// corresponding conformance pack, then project out the
5724-
// appropriate lane.
5725-
llvm_unreachable("unimplemented");
5722+
// FIXME: This violates the spirit of this verifier check.
5723+
return protocol->getParentModule()
5724+
->lookupConformance(conformingType, protocol);
57265725
};
57275726

57285727
// If the pack components and expected element types are SIL types,

0 commit comments

Comments
 (0)