update validation tests to modern syntax.

Author: lattner

validation-test/Evolution/Inputs/function_change_transparent_body.swift

@@ -15,7 +15,7 @@ public func getVersion() -> Int {
 #endif
 }
 
-public func getFunction(_ x: Int) -> Int -> Int {
+public func getFunction(_ x: Int) -> (Int) -> Int {
   // Force a re-abstraction thunk for (T -> T) => (Int -> Int) to be
   // emitted from a non-transparent context first
 
@@ -28,7 +28,7 @@ public func getFunction(_ x: Int) -> Int -> Int {
   return id
 }
 
-@_transparent public func getTransparentFunction(_ x: Int) -> Int -> Int {
+@_transparent public func getTransparentFunction(_ x: Int) -> (Int) -> Int {
   // The mangled name and calling convention of the local function
   // will change -- so we must serialize it and inline it into
   // the calling module

validation-test/compiler_crashers_2_fixed/0013-rdar19519590.swift

@@ -5,7 +5,7 @@ protocol SourceTargetTransformable {
     associatedtype Target
 
     // FIXME: should really be a typealias once we support that
-    associatedtype Transformer = Source -> Target
+    associatedtype Transformer = (Source) -> Target
 }
 
 
@@ -32,7 +32,7 @@ struct PiecewiseTransformedIteratorOf<
         if let source: Transformable.Source = source {
             let transformer: Transformable.Transformer? = transformerIterator.next()
             if let transformer: Transformable.Transformer = transformer {
-                let tfunc: (Source -> Target)? = transformer as? (Source -> Target)
+                let tfunc: ((Source) -> Target)? = transformer as? ((Source) -> Target)
                 if let tfunc = tfunc {
                     return tfunc(source)
                 }

validation-test/compiler_crashers_2_fixed/0022-rdar21625478.swift

@@ -20,19 +20,19 @@ public protocol MySequence {
   var underestimatedCount: Int { get }
 
   func map<T>(
-    @noescape _ transform: (Iterator.Element) -> T
+    _ transform: @noescape (Iterator.Element) -> T
   ) -> [T]
 
   func filter(
-    @noescape _ includeElement: (Iterator.Element) -> Bool
+    _ includeElement: @noescape (Iterator.Element) -> Bool
   ) -> [Iterator.Element]
 
   func _customContainsEquatableElement(
     _ element: Iterator.Element
   ) -> Bool?
 
   func _preprocessingPass<R>(
-    @noescape _ preprocess: (Self) -> R
+    _ preprocess: @noescape (Self) -> R
   ) -> R?
 
   func _copyToNativeArrayBuffer()
@@ -48,13 +48,13 @@ extension MySequence {
   }
 
   public func map<T>(
-    @noescape _ transform: (Iterator.Element) -> T
+    _ transform: @noescape (Iterator.Element) -> T
   ) -> [T] {
     return []
   }
 
   public func filter(
-    @noescape _ includeElement: (Iterator.Element) -> Bool
+    _ includeElement: @noescape (Iterator.Element) -> Bool
   ) -> [Iterator.Element] {
     return []
   }
@@ -66,7 +66,7 @@ extension MySequence {
   }
 
   public func _preprocessingPass<R>(
-    @noescape _ preprocess: (Self) -> R
+    _ preprocess: @noescape (Self) -> R
   ) -> R? {
     return nil
   }
@@ -111,7 +111,7 @@ extension MyCollection {
     return startIndex == endIndex
   }
   public func _preprocessingPass<R>(
-    @noescape _ preprocess: (Self) -> R
+    _ preprocess: @noescape (Self) -> R
   ) -> R? {
     return preprocess(self)
   }
@@ -249,14 +249,14 @@ extension LoggingSequenceType
   }
 
   public func map<T>(
-    @noescape _ transform: (Base.Iterator.Element) -> T
+    _ transform: @noescape (Base.Iterator.Element) -> T
   ) -> [T] {
     Log.map[selfType] += 1
     return base.map(transform)
   }
 
   public func filter(
-    @noescape _ includeElement: (Base.Iterator.Element) -> Bool
+    _ includeElement: @noescape (Base.Iterator.Element) -> Bool
   ) -> [Base.Iterator.Element] {
     Log.filter[selfType] += 1
     return base.filter(includeElement)
@@ -273,7 +273,7 @@ extension LoggingSequenceType
   /// `preprocess` on `self` and return its result.  Otherwise, return
   /// `nil`.
   public func _preprocessingPass<R>(
-    @noescape _ preprocess: (Self) -> R
+    _ preprocess: @noescape (Self) -> R
   ) -> R? {
     Log._preprocessingPass[selfType] += 1
     return base._preprocessingPass { _ in preprocess(self) }

validation-test/compiler_crashers_2_fixed/0034-rdar21982453.swift

@@ -1,7 +1,7 @@
 // RUN: %target-swift-frontend %s -emit-silgen
 
 func a() {
-    func f(x: Void -> Any) { }
+    func f(x: (Void) -> Any) { }
     var g = { 3 }
     f { g }
 }

validation-test/compiler_crashers_fixed/00012-emitdirecttypemetadataref.swift

@@ -12,7 +12,7 @@
 // http://www.openradar.me/17822208
 // https://twitter.com/rob_rix/status/493199478879682561
 
-func a<T>() -> (T, T -> T) -> T {
-    var b: ((T, T -> T) -> T)!
+func a<T>() -> (T, (T) -> T) -> T {
+    var b: ((T, (T) -> T) -> T)!
     return b
 }

validation-test/stdlib/Arrays.swift.gyb

@@ -306,7 +306,7 @@ ArrayTestSuite.test("${array_type}/map") {
 }
 
 ArrayTestSuite.test("${array_type}/flatMap") {
-  let enumerate : Int -> ${array_type}<Int> =
+  let enumerate : (Int) -> ${array_type}<Int> =
     { return ${array_type}(1..<($0 + 1)) }
   expectEqualSequence([], ${array_type}().flatMap(enumerate))
   expectEqualSequence([ 1 ], ${array_type}([ 1 ]).flatMap(enumerate))

validation-test/stdlib/Collection/LazyFilterCollection.swift.gyb

@@ -96,7 +96,7 @@ CollectionTests.test("LazyFilterCollection instances (${traversal}${kind})") {
 % end
   }
   do {
-    let predicate: Int -> Bool = { $0 % 3 == 0 || $0 % 5 == 0 }
+    let predicate: (Int) -> Bool = { $0 % 3 == 0 || $0 % 5 == 0 }
 
     let base = randArray(500)
     var expected : [Int] = []

validation-test/stdlib/FixedPointArithmeticTraps.swift.gyb

@@ -18,7 +18,7 @@ import StdlibUnittest
 func expectOverflow<T>(
   _ res: (T, overflow: Bool),
   //===--- TRACE boilerplate ----------------------------------------------===//
-  @autoclosure _ message: () -> String = "",
+  _ message: @autoclosure () -> String = "",
     showFrame: Bool = true,
     stackTrace: SourceLocStack = SourceLocStack(),  
     file: String = #file, line: UInt = #line
@@ -31,7 +31,7 @@ func expectOverflow<T>(
 func expectNoOverflow<T>(
   _ res: (T, overflow: Bool),
   //===--- TRACE boilerplate ----------------------------------------------===//
-  @autoclosure _ message: () -> String = "",
+  _ message: @autoclosure () -> String = "",
     showFrame: Bool = true,
     stackTrace: SourceLocStack = SourceLocStack(),  
     file: String = #file, line: UInt = #line

validation-test/stdlib/SequenceType.swift.gyb

@@ -770,7 +770,7 @@ struct MinimalSequenceWith${Implementation}Map<Element> : Sequence {
   }
 
   func map<T>(
-    @noescape _ transform: (Element) throws -> T
+    _ transform: @noescape (Element) throws -> T
   ) rethrows -> [T] {
     MinimalSequenceWithCustomMap.timesMapWasCalled += 1
     return try _data.map(transform)
@@ -783,7 +783,7 @@ struct MinimalSequenceWith${Implementation}Map<Element> : Sequence {
 
 func callStaticSequenceMap<T>(
   _ sequence: MinimalSequenceWithDefaultMap<OpaqueValue<Int>>,
-  @noescape transform: (OpaqueValue<Int>) -> T
+  transform: @noescape (OpaqueValue<Int>) -> T
 ) -> [T] {
   var result = sequence.map(transform)
   expectType([T].self, &result)
@@ -792,7 +792,7 @@ func callStaticSequenceMap<T>(
 
 func callStaticSequenceMap<T>(
   _ sequence: MinimalSequenceWithCustomMap<OpaqueValue<Int>>,
-  @noescape transform: (OpaqueValue<Int>) -> T
+  transform: @noescape (OpaqueValue<Int>) -> T
 ) -> [T] {
   var result = sequence.map(transform)
   expectType([T].self, &result)
@@ -801,7 +801,7 @@ func callStaticSequenceMap<T>(
 
 func callGenericSequenceMap<S : Sequence, T>(
   _ sequence: S,
-  @noescape transform: (S.Iterator.Element) -> T
+  transform: @noescape (S.Iterator.Element) -> T
 ) -> [T] {
   var result = sequence.map(transform)
   expectType([T].self, &result)

validation-test/stdlib/SequenceWrapperTest.swift

@@ -29,11 +29,11 @@ let indirect = LoggingSequence(wrapping: direct)
 let dispatchLog = base.log
 
 func expectWrapperDispatch<R1, R2>(
-  @autoclosure _ directOperation: () -> R1,
-  @autoclosure _ indirectOperation: () -> R2,
+  _ directOperation: @autoclosure () -> R1,
+  _ indirectOperation: @autoclosure () -> R2,
   _ counters: TypeIndexed<Int>,
   //===--- TRACE boilerplate ----------------------------------------------===//
-  @autoclosure _ message: () -> String = "",
+  _ message: @autoclosure () -> String = "",
   showFrame: Bool = true,
   stackTrace: SourceLocStack = SourceLocStack(),  
   file: String = #file, line: UInt = #line