Gardening: Migrate test suite to GH issues: AutoDiff/compiler_crashers_fixed (1/2)

AnthonyLatsis · AnthonyLatsis · commit 8872fe6b3022 · 2022-09-19T02:36:02.000+03:00
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-54935-differentiable-function-extract-subst-function-type.swift b/test/AutoDiff/compiler_crashers_fixed/issue-54935-differentiable-function-extract-subst-function-type.swift
@@ -1,9 +1,10 @@
 // RUN: %target-build-swift -O %s
 
-// SR-12493: SIL verification error regarding substituted function types and
+// https://github.com/apple/swift/issues/54935
+// SIL verification error regarding substituted function types and
 // `differentiable_function_extract` instruction. Occurs only with `-O`.
 
-// FIXME(SR-13021): Disabled due to flakiness on Linux, likely related to TF-1197.
+// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
 // REQUIRES: SR13021
 
 import _Differentiation
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-54992-siloptimizer-rewrite-partial-apply-convention-method.swift b/test/AutoDiff/compiler_crashers_fixed/issue-54992-siloptimizer-rewrite-partial-apply-convention-method.swift
@@ -1,8 +1,8 @@
 // RUN: %target-build-swift -O %s
 
-// SR-12548: SIL verification error regarding
-// `CapturePropagation::rewritePartialApply` for `partial_apply` with
-// `@convention(method)` callee.
+// https://github.com/apple/swift/issues/54992
+// SIL verification error regarding `CapturePropagation::rewritePartialApply`
+// for `partial_apply` with `@convention(method)` callee
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55003-derivative-attr-type-checking-parse-stdlib.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55003-derivative-attr-type-checking-parse-stdlib.swift
@@ -1,6 +1,8 @@
 // RUN: not %target-swift-frontend-typecheck -parse-stdlib %s
 
-// SR-12559: `@derivative` attribute type-checking crash.
+// https://github.com/apple/swift/issues/55003
+// `@derivative` attribute type-checking crash
+//
 // This program is not valid, but the compiler should not crash nonetheless.
 // Reproducible only with `-parse-stdlib`.
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55085-silgen-immutable-address-use-verification-failure.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55085-silgen-immutable-address-use-verification-failure.swift
@@ -1,6 +1,8 @@
 // RUN: %target-swift-frontend -enable-resilience -emit-sil -verify %s
 
-// SR-12641: SILGen verification error regarding `ImmutableAddressUseVerifier` and AutoDiff-generated code.
+// https://github.com/apple/swift/issues/55085
+// SILGen verification error regarding `ImmutableAddressUseVerifier`
+// and AutoDiff-generated code.
 
 import _Differentiation
 
@@ -32,7 +34,7 @@ _ = pullback(at: Class(Resilient(x: 10)), of: f)
 //  #9 0x00000000011e6add (anonymous namespace)::ImmutableAddressUseVerifier::isMutatingOrConsuming(swift::SILValue)
 // #10 0x00000000011ce0b4 (anonymous namespace)::SILVerifier::visitSILBasicBlock(swift::SILBasicBlock*)
 
-// Related crasher discovered while fixing SR-12641.
+// Related crasher discovered while fixing the aforementioned issue.
 
 class LoadableOriginal<T: Differentiable>: Differentiable {
   var x: T
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55086-differentiable-derivation-redeclared-property.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55086-differentiable-derivation-redeclared-property.swift
@@ -1,8 +1,11 @@
 // RUN: %target-swift-frontend -typecheck -verify %s
 
-// SR-12642: Crash regarding `Differentiable` derived conformances and
-// redeclared properties. This crash surfaced only briefly during the
-// implementation of wrapped property differentiation (SR-12637).
+// https://github.com/apple/swift/issues/55086
+// Crash regarding `Differentiable` derived conformances and redeclared
+// properties
+//
+// This crash surfaced only briefly during the implementation of wrapped
+// property differentiation (https://github.com/apple/swift/issues/55081).
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55094-noderivative-parameter-type-mangling.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55094-noderivative-parameter-type-mangling.swift
@@ -1,9 +1,10 @@
 // RUN: %target-build-swift -g %s
 
-// SR-12650: IRGenDebugInfo type reconstruction crash because `@noDerivative`
-// parameters are not mangled.
+// https://github.com/apple/swift/issues/55094
+// IRGenDebugInfo type reconstruction crash because `@noDerivative` parameters
+// are not mangled
 
-// FIXME(SR-13021): Disabled due to flakiness on Linux, likely related to TF-1197.
+// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
 // REQUIRES: SR13021
 
 import _Differentiation
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55099-differentiation-opaque-result-type.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55099-differentiation-opaque-result-type.swift
@@ -1,6 +1,7 @@
 // RUN: not %target-swift-frontend -disable-availability-checking -emit-sil -verify %s
 
-// SR-12656: Differentiation transform crashes for original function with opaque
+// https://github.com/apple/swift/issues/55099
+// Differentiation transform crashes for original function with opaque
 // result type.
 //
 // If supporting this is non-trivial, we could reject earlier during Sema.
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55177-optimize-partial-apply-convention-thin-only.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55177-optimize-partial-apply-convention-thin-only.swift
@@ -1,11 +1,12 @@
 // RUN: %target-build-swift -Osize %s
 
-// SR-12732: Fix `partial_apply` optimization.
+// https://github.com/apple/swift/issues/55177
+// Fix `partial_apply` optimization
 
 // Do not rewrite `partial_apply` to `thin_to_thick_function` if the specialized
 // callee is not `@convention(thin)`.
 
-// FIXME(SR-13021): Disabled due to flakiness on Linux, likely related to TF-1197.
+// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
 // REQUIRES: SR13021
 
 import DifferentiationUnittest
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55189-unhandled-pullback-indirect-result.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55189-unhandled-pullback-indirect-result.swift
@@ -1,6 +1,8 @@
 // RUN: %target-swift-frontend -emit-sil -verify %s
 
-// SR-12744: Pullback generation crash for unhandled indirect result.
+// https://github.com/apple/swift/issues/55189
+// Pullback generation crash for unhandled indirect result
+//
 // May be due to inconsistent derivative function type calculation logic in
 // `VJPEmitter::createEmptyPullback`.
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55333-55334-vjp-emitter-definite-initialization.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55333-55334-vjp-emitter-definite-initialization.swift
@@ -3,13 +3,15 @@
 
 // Test crashes related to differentiation and definite initialization.
 
-// SR-12886: SIL memory lifetime verification error due to
-// `SILCloner::visitAllocStack` not copying the `[dynamic_lifetime]` attribute.
+// https://github.com/apple/swift/issues/55333
+// SIL memory lifetime verification error due to `SILCloner::visitAllocStack`
+// not copying the `[dynamic_lifetime]` attribute
 
-// SR-12887: Debug scope error for pullback struct `struct` instruction
-// generated by `VJPEmitter`.
+// https://github.com/apple/swift/issues/55334
+// Debug scope error for pullback struct `struct` instruction generated
+// by `VJPEmitter`
 
-// FIXME(SR-13021): Disabled due to flakiness on Linux, likely related to TF-1197.
+// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
 // REQUIRES: SR13021
 
 import _Differentiation
@@ -44,11 +46,11 @@ struct Tensor<T>: Differentiable {
 // CHECK-LABEL: sil hidden @AD__$s4main6TensorVyACyxGx_ADtcfC__vjp_src_0_wrt_1_l : $@convention(method) <τ_0_0> (@in τ_0_0, @in Tensor<τ_0_0>, @thin Tensor<τ_0_0>.Type) -> (@out Tensor<τ_0_0>, @owned @callee_guaranteed @substituted <τ_0_0, τ_0_1> (@in_guaranteed τ_0_0) -> @out τ_0_1 for <Tensor<τ_0_0>.TangentVector, Tensor<τ_0_0>.TangentVector>) {
 // CHECK: [[SELF_ALLOC:%.*]] = alloc_stack [dynamic_lifetime] $Tensor<τ_0_0>, var, name "self"
 
-// SR-12886 original error:
+// Original error in https://github.com/apple/swift/issues/55333:
 // SIL memory lifetime failure in @AD__$s5crash6TensorVyACyxGx_ADtcfC__vjp_src_0_wrt_1_l: memory is not initialized, but should
 // memory location:   %29 = struct_element_addr %5 : $*Tensor<τ_0_0>, #Tensor.x // user: %30
 // at instruction:   destroy_addr %29 : $*τ_0_0                     // id: %30
 
-// SR-12887 original error:
+// Original error in https://github.com/apple/swift/issues/55334:
 // SIL verification failed: Basic block contains a non-contiguous lexical scope at -Onone: DS == LastSeenScope
 // %26 = struct $_AD__$s5crash6TensorVyACyxGx_ADtcfC_bb0__PB__src_0_wrt_1_l<τ_0_0> () // users: %34, %28
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-55745-noderivative-inout-parameter.swift b/test/AutoDiff/compiler_crashers_fixed/issue-55745-noderivative-inout-parameter.swift
@@ -2,16 +2,17 @@
 
 import _Differentiation
 
-// SR-13305: Test protocol witness thunk for `@differentiable` protocol
-// requirement, where the required method has a non-wrt `inout` parameter
-// that should be treated as a differentiability result.
+// https://github.com/apple/swift/issues/55745
+// Test protocol witness thunk for `@differentiable` protocol requirement, where
+// the required method has a non-wrt `inout` parameter that should be treated as
+// a differentiability result.
 
-protocol SR_13305_Protocol {
+protocol Proto {
   @differentiable(reverse, wrt: x)
   func method(x: Float, y: inout Float)
 }
 
-struct SR_13305_Struct: SR_13305_Protocol {
+struct Struct: Proto {
   @differentiable(reverse, wrt: x)
   func method(x: Float, y: inout Float) {
     y = y * x
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-56263-library-evolution-mode-crasher-property-differentiation.swift b/test/AutoDiff/compiler_crashers_fixed/issue-56263-library-evolution-mode-crasher-property-differentiation.swift
@@ -1,6 +1,7 @@
 // RUN: %target-swift-frontend -c -enable-library-evolution %s
 
-// SR-13865: AutoDiff crasher on property derivatives in library evolution mode.
+// https://github.com/apple/swift/issues/56263
+// AutoDiff crasher on property derivatives in library evolution mode
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-56330-vjpcloner-apply-multiple-consuming-users.swift b/test/AutoDiff/compiler_crashers_fixed/issue-56330-vjpcloner-apply-multiple-consuming-users.swift
@@ -2,8 +2,9 @@
 // Every so often, this test causes the linker to crash!
 // REQUIRES: rdar86041709
 
-// SR-13933: Fix "multiple consuming users" ownership error caused by
-// `VJPCloner::visitApply` related to `@differentiable`-function-typed callees.
+// https://github.com/apple/swift/issues/56330
+// Fix "multiple consuming users" ownership error caused by
+// `VJPCloner::visitApply` related to `@differentiable`-function-typed callees
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-56397-cross-module-differentiation-differentiable-function-extract-inlining.swift b/test/AutoDiff/compiler_crashers_fixed/issue-56397-cross-module-differentiation-differentiable-function-extract-inlining.swift
@@ -2,7 +2,8 @@
 // RUN: %target-build-swift-dylib(%t/%target-library-name(Library)) -emit-module -emit-module-path %t/Library.swiftmodule -module-name Library -DLIBRARY %s
 // RUN: %target-build-swift -I %t -O -emit-module %s
 
-// SR-14004: Assertion failure due to function with `differentiable_function_extract`
+// https://github.com/apple/swift/issues/56397
+// Assertion failure due to function with `differentiable_function_extract`
 // with explicit extractee type being deserialized into a raw SIL module.
 
 #if LIBRARY
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-56600-symbol-in-ir-file-not-tbd-file.swift b/test/AutoDiff/compiler_crashers_fixed/issue-56600-symbol-in-ir-file-not-tbd-file.swift
@@ -2,8 +2,9 @@
 
 // REQUIRES: executable_test
 
-// SR-14240: Error: symbol 'powTJfSSpSr' (powTJfSSpSr) is in generated IR file,
-// but not in TBD file.
+// https://github.com/apple/swift/issues/56600
+// Error: symbol 'powTJfSSpSr' (powTJfSSpSr) is in generated IR file, but not
+// in TBD file
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-56649-missing-debug-scopes-in-pullback-trampoline.swift b/test/AutoDiff/compiler_crashers_fixed/issue-56649-missing-debug-scopes-in-pullback-trampoline.swift
@@ -1,7 +1,9 @@
 // RUN: %target-build-swift %s
 // RUN: %target-swift-frontend -c -g -Xllvm -verify-di-holes=true %s
 
-// rdar://74876596 ([SR-14290]: SIL verification fails when differentiating a function of [[Double]])
+// rdar://74876596
+// https://github.com/apple/swift/issues/56649
+// SIL verification fails when differentiating a function of `[[Double]]`
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-56977-over-consume-in-subset-parameters-thunk.swift b/test/AutoDiff/compiler_crashers_fixed/issue-56977-over-consume-in-subset-parameters-thunk.swift
@@ -1,7 +1,7 @@
 // RUN: %target-build-swift %s
 
-// SR-14625: An over-consume in a subset parameters thunk detected after
-// enabling OSSA.
+// https://github.com/apple/swift/issues/56977
+// An over-consume in a subset parameters thunk detected after enabling OSSA
 
 // The test is flaky and crashes in some CI builds
 // REQUIRES: rdar86063852
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-57527-diff-capture.swift b/test/AutoDiff/compiler_crashers_fixed/issue-57527-diff-capture.swift
@@ -1,7 +1,8 @@
 // RUN: %target-swift-frontend -emit-sil -verify %s
 
-// SR-15205: fix assertions related to captured arguments, they should
-// treated as constants
+// https://github.com/apple/swift/issues/57527
+// Fix assertions related to captured arguments, they should be treated
+// as constants.
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-57869-vardecl-adjoint-values.swift b/test/AutoDiff/compiler_crashers_fixed/issue-57869-vardecl-adjoint-values.swift
@@ -4,7 +4,8 @@
 // Every so often this test crashes the linker on Linux
 // REQUIRES: rdar87254800
 
-// SR-15566: Differentiable functions with control flow yield an assertion failure: "location is a VarDecl, but SILDebugVariable is empty"
+// https://github.com/apple/swift/issues/57869
+// Differentiable functions with control flow yield an assertion failure
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-58123-invalid-debug-info.swift b/test/AutoDiff/compiler_crashers_fixed/issue-58123-invalid-debug-info.swift
@@ -1,7 +1,9 @@
-// SR-15849: Mutating functions with control flow can cause assertion failure
-// for conflicting debug variable type.
-
 // RUN: %target-swift-frontend -emit-ir -O -g %s | %FileCheck %s
+
+// https://github.com/apple/swift/issues/58123
+// Mutating functions with control flow can cause assertion failure for
+// conflicting debug variable type
+
 // CHECK-LABEL: define internal swiftcc float @"$s4main8TestTypeV24doDifferentiableTimeStep04timeG0ySf_tFTJpSSpSrTA"
 // CHECK: [[SELF:%.*]] = alloca %T4main8TestTypeV06ManualB7TangentV, align 4
 // CHECK: call void @llvm.dbg.declare(metadata %T4main8TestTypeV06ManualB7TangentV* [[SELF]]
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-58123-mutating-functions-with-control-flow.swift b/test/AutoDiff/compiler_crashers_fixed/issue-58123-mutating-functions-with-control-flow.swift
@@ -1,8 +1,9 @@
 // RUN: %empty-directory(%t)
-// RUN: %target-build-swift -O -g -debug-info-format=dwarf -emit-module -module-name sr15849 -emit-module-path %t/sr15849.swiftmodule -swift-version 5 -c %S/sr15849-mutating-functions-with-control-flow.swift
+// RUN: %target-build-swift -O -g -debug-info-format=dwarf -emit-module -module-name M -emit-module-path %t/M.swiftmodule -swift-version 5 -c %s
 
-// SR-15849: Mutating functions with control flow can cause assertion failure
-// for conflicting debug variable type.
+// https://github.com/apple/swift/issues/58123
+// Mutating functions with control flow can cause assertion failure for
+// conflicting debug variable type
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-58149-generic-signature-builder-keypath-iterable.swift b/test/AutoDiff/compiler_crashers_fixed/issue-58149-generic-signature-builder-keypath-iterable.swift
@@ -1,9 +1,12 @@
 // RUN: %target-swift-frontend -emit-sil -verify %s
 
-// SR-15884: Crash while compiling Swift for TensorFlow. This was caused by a
-// bug in GenericSignatureBuilder, similar to one involving `CaseIterable`. In
-// this reproducer, `KeyPathIterabe` is similar enough to `CaseIterable` to 
-// cause the GSB crash. It was fixed by RequirementMachine abstract signatures.
+// https://github.com/apple/swift/issues/58149
+// Crash while compiling Swift for TensorFlow
+//
+// This was caused by a bug in GenericSignatureBuilder, similar to one involving
+// `CaseIterable`. In this reproducer, `KeyPathIterable` is similar enough to
+// `CaseIterable` to have caused the GSB to crash. It was fixed by
+// RequirementMachine abstract signatures.
 
 import _Differentiation
 @_spi(Reflection) import Swift
diff --git a/test/AutoDiff/compiler_crashers_fixed/issue-58152-inout-adjoint-param-idx.swift b/test/AutoDiff/compiler_crashers_fixed/issue-58152-inout-adjoint-param-idx.swift
@@ -1,9 +1,9 @@
 // RUN: %target-swift-frontend -emit-sil -verify %s
 
-// SR-15891: The parameter indices used for copying
-// inout tangent vectors were calculated improperly
-// in presence of other pullback parameters (e.g. 
-// captures)
+// https://github.com/apple/swift/issues/58152
+// The parameter indices used for copying `inout` tangent vectors were
+// calculated improperly in presence of other pullback parameters
+// (e.g. captures).
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/sr13411-tangent-value-category-mismatch.swift b/test/AutoDiff/compiler_crashers_fixed/sr13411-tangent-value-category-mismatch.swift
@@ -1,6 +1,8 @@
 // RUN: %target-build-swift %s
 
-// SR-13411: Semantic member getter pullback generation crash due to tangent value category mismatch
+// https://github.com/apple/swift/issues/55852
+// Semantic member getter pullback generation crash due to tangent value
+// category mismatch
 
 import _Differentiation
 
diff --git a/test/AutoDiff/compiler_crashers_fixed/tf1232-autodiff-generated-declaration-mangling.swift b/test/AutoDiff/compiler_crashers_fixed/tf1232-autodiff-generated-declaration-mangling.swift
@@ -1,5 +1,5 @@
 // RUN: %target-build-swift -g %s
-// This test occasionally fails to link.
+// FIXME: This test occasionally fails to link (https://github.com/apple/swift/issues/57125).
 // REQUIRES: SR14775
 
 // TF-1232: IRGenDebugInfo crash due to lack of proper mangling for
