Skip to content

Commit 8c0c666

Browse files
committed
[Diagnostics] Make sure we provide the proper file name
1 parent f3ff1b4 commit 8c0c666

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

include/swift/Frontend/PrintingDiagnosticConsumer.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ class PrintingDiagnosticConsumer : public DiagnosticConsumer {
9494

9595
private:
9696
/// Retrieve the SourceFileSyntax for the given buffer.
97-
void *getSourceFileSyntax(SourceManager &SM, unsigned bufferID);
97+
void *getSourceFileSyntax(SourceManager &SM, unsigned bufferID,
98+
StringRef displayName);
9899

99100
void queueBuffer(SourceManager &sourceMgr, unsigned bufferID);
100101
void printDiagnostic(SourceManager &SM, const DiagnosticInfo &Info);

lib/Frontend/PrintingDiagnosticConsumer.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,15 +305,15 @@ static SmallVector<unsigned, 1> getSourceBufferStack(
305305
}
306306

307307
void *PrintingDiagnosticConsumer::getSourceFileSyntax(
308-
SourceManager &sourceMgr, unsigned bufferID) {
308+
SourceManager &sourceMgr, unsigned bufferID, StringRef displayName) {
309309
auto known = sourceFileSyntax.find({&sourceMgr, bufferID});
310310
if (known != sourceFileSyntax.end())
311311
return known->second;
312312

313313
auto bufferContents = sourceMgr.getEntireTextForBuffer(bufferID);
314314
auto sourceFile = swift_ASTGen_parseSourceFile(
315315
bufferContents.data(), bufferContents.size(),
316-
"module", "file.swift", /*ctx*/ nullptr);
316+
"module", displayName.str().c_str(), /*ctx*/ nullptr);
317317

318318
sourceFileSyntax[{&sourceMgr, bufferID}] = sourceFile;
319319
return sourceFile;
@@ -355,7 +355,7 @@ void PrintingDiagnosticConsumer::queueBuffer(
355355
sourceMgr.getLocForBufferStart(bufferID)).str();
356356
}
357357

358-
auto sourceFile = getSourceFileSyntax(sourceMgr, bufferID);
358+
auto sourceFile = getSourceFileSyntax(sourceMgr, bufferID, displayName);
359359
swift_ASTGen_addQueuedSourceFile(
360360
queuedDiagnostics, bufferID, sourceFile,
361361
(const uint8_t*)displayName.data(), displayName.size(),

0 commit comments

Comments
 (0)