Merge pull request #74690 from tshortli/accessor-availability-reference-types

Sema: Suppress set accessor availability diagnostics in `LoadExpr`s

Author: tshortli

lib/Sema/TypeCheckAvailability.cpp

@@ -3524,13 +3524,19 @@ class ExprAvailabilityWalker : public ASTWalker {
     return call;
   }
 
-  /// Walks up to the first enclosing LoadExpr and returns it.
+  /// Walks up from a potential member reference to the first LoadExpr that would
+  /// make the member reference an r-value instead of an l-value.
   const LoadExpr *getEnclosingLoadExpr() const {
     assert(!ExprStack.empty() && "must be called while visiting an expression");
     ArrayRef<const Expr *> stack = ExprStack;
     stack = stack.drop_back();
 
     for (auto expr : llvm::reverse(stack)) {
+      // Do not search past the first enclosing ApplyExpr. Any enclosing
+      // LoadExpr from this point only applies to the result of the call.
+      if (auto applyExpr = dyn_cast<ApplyExpr>(expr))
+        return nullptr;
+
       if (auto loadExpr = dyn_cast<LoadExpr>(expr))
         return loadExpr;
     }
@@ -3631,12 +3637,7 @@ class ExprAvailabilityWalker : public ASTWalker {
 
   /// Walk an inout expression, checking for availability.
   void walkInOutExpr(InOutExpr *E) {
-    // If there is a LoadExpr in the stack, then this InOutExpr is not actually
-    // indicative of any mutation so the access context should just be Getter.
-    auto accessContext = getEnclosingLoadExpr() ? MemberAccessContext::Getter
-                                                : MemberAccessContext::InOut;
-
-    walkInContext(E, E->getSubExpr(), accessContext);
+    walkInContext(E, E->getSubExpr(), MemberAccessContext::InOut);
   }
 
   bool shouldWalkIntoClosure(AbstractClosureExpr *closure) const {
@@ -3657,7 +3658,6 @@ class ExprAvailabilityWalker : public ASTWalker {
     return;
   }
 
-
   /// Walk the given expression in the member access context.
   void walkInContext(Expr *baseExpr, Expr *E,
                      MemberAccessContext AccessContext) {
@@ -3693,18 +3693,22 @@ class ExprAvailabilityWalker : public ASTWalker {
       break;
 
     case MemberAccessContext::Setter:
-      diagAccessorAvailability(D->getOpaqueAccessor(AccessorKind::Set),
-                               ReferenceRange, ReferenceDC, std::nullopt);
+      if (!getEnclosingLoadExpr()) {
+        diagAccessorAvailability(D->getOpaqueAccessor(AccessorKind::Set),
+                                 ReferenceRange, ReferenceDC, std::nullopt);
+      }
       break;
 
     case MemberAccessContext::InOut:
       diagAccessorAvailability(D->getOpaqueAccessor(AccessorKind::Get),
                                ReferenceRange, ReferenceDC,
                                DeclAvailabilityFlag::ForInout);
 
-      diagAccessorAvailability(D->getOpaqueAccessor(AccessorKind::Set),
-                               ReferenceRange, ReferenceDC,
-                               DeclAvailabilityFlag::ForInout);
+      if (!getEnclosingLoadExpr()) {
+        diagAccessorAvailability(D->getOpaqueAccessor(AccessorKind::Set),
+                                 ReferenceRange, ReferenceDC,
+                                 DeclAvailabilityFlag::ForInout);
+      }
       break;
     }
   }