Merge pull request #69567 from tshortli/module-interface-lazy-typecheck-transparent-attr

AST: Expand @_transparent in SemanticDeclAttrsRequest

Author: tshortli

lib/AST/TypeCheckRequests.cpp

@@ -2069,9 +2069,15 @@ void ExpandPeerMacroRequest::noteCycleStep(DiagnosticEngine &diags) const {
 
 DeclAttributes SemanticDeclAttrsRequest::evaluate(Evaluator &evaluator,
                                                   const Decl *decl) const {
+  // Expand attributes contributed by attached macros.
   auto mutableDecl = const_cast<Decl *>(decl);
   (void)evaluateOrDefault(evaluator, ExpandMemberAttributeMacros{mutableDecl},
                           {});
+
+  // Trigger requests that cause additional semantic attributes to be added.
+  if (auto afd = dyn_cast<AbstractFunctionDecl>(decl)) {
+    (void)afd->isTransparent();
+  }
   return decl->getAttrs();
 }
 

lib/Sema/TypeCheckStorage.cpp

@@ -821,7 +821,7 @@ static bool doesAccessorHaveBody(AccessorDecl *accessor) {
   auto *storage = accessor->getStorage();
 
   // NSManaged getters and setters don't have bodies.
-  if (storage->getAttrs().hasAttribute<NSManagedAttr>())
+  if (storage->getAttrs().hasAttribute<NSManagedAttr>(/*AllowInvalid=*/true))
     if (accessor->isGetterOrSetter())
       return false;
 

test/Inputs/lazy_typecheck.swift

@@ -128,6 +128,9 @@ public struct PublicStruct {
   public var publicProperty: Int
   public var publicPropertyInferredType = ""
   @PublicWrapper public var publicWrappedProperty = 3.14
+  @_transparent public var publicTransparentProperty: Int {
+    get { return 1 }
+  }
 
   public init(x: Int) {
     self.publicProperty = 1

test/Inputs/lazy_typecheck_client.swift

@@ -39,6 +39,7 @@ func testPublicStruct() {
   let _: String = s.publicPropertyInferredType
   let _: Double = s.publicWrappedProperty
   let _: Double = s.$publicWrappedProperty.wrappedValue
+  let _: Int = s.publicTransparentProperty
   PublicStruct.publicStaticMethod()
   PublicStruct.activeMethod()
 }

test/ModuleInterface/stored-properties.swift

@@ -38,7 +38,8 @@ public struct HasStoredProperties {
 
   // CHECK: @_hasStorage public var storedWithObservers: Swift.Bool {
   // RESILIENT:   {{^}}  public var storedWithObservers: Swift.Bool {
-  // COMMON-NEXT: {{^}}    get
+  // CHECK-NEXT:  {{^}}    @_transparent get
+  // RESILIENT-NEXT: {{^}} get
   // COMMON-NEXT: {{^}}    set
   // COMMON-NEXT: {{^}}  }
   public var storedWithObservers: Bool {