Merge pull request #36918 from slavapestov/error-existential-metatype

Sema: Handle Error self-conformance in TypeChecker::containsProtocol()

Author: slavapestov

lib/Sema/TypeCheckProtocol.cpp

@@ -4990,6 +4990,14 @@ TypeChecker::containsProtocol(Type T, ProtocolDecl *Proto, DeclContext *DC,
   // Existential types don't need to conform, i.e., they only need to
   // contain the protocol.
   if (T->isExistentialType()) {
+    // Handle the special case of the Error protocol, which self-conforms
+    // *and* has a witness table.
+    if (T->isEqual(Proto->getDeclaredInterfaceType()) &&
+        Proto->requiresSelfConformanceWitnessTable()) {
+      auto &ctx = DC->getASTContext();
+      return ProtocolConformanceRef(ctx.getSelfConformance(Proto));
+    }
+
     auto layout = T->getExistentialLayout();
 
     // First, if we have a superclass constraint, the class may conform

validation-test/compiler_crashers_2_fixed/rdar70338670.swift

@@ -0,0 +1,12 @@
+// RUN: %target-swift-frontend -emit-ir %s
+
+public struct X {
+  public subscript(_ key: String, as type: Error.Type = Error.self) -> Error? {
+    get {
+      return nil
+    }
+  }
+}
+
+let x = X()
+_ = x["hi"]