Merge pull request #60957 from AnthonyLatsis/migrate-test-suite-to-gh-issues-23

Gardening: Migrate test suite to GH issues p. 23

Author: AnthonyLatsis

test/SymbolGraph/Module/ExportedImport.swift

@@ -14,6 +14,6 @@
 // CHECK-DAG: "precise":"s:1B9StructOneV"
 
 // FIXME: Symbols from `@_exported import` do not get emitted when using swift-symbolgraph-extract
-// This is tracked by https://bugs.swift.org/browse/SR-15921.
+// This is tracked by https://github.com/apple/swift-docc/issues/179.
 
 // FILES-NOT: [email protected]

test/TypeDecoder/generic_typealias.swift

@@ -61,7 +61,7 @@ do {
 }
 
 do {
-  // FIXME: https://bugs.swift.org/browse/SR-9762
+  // FIXME: https://github.com/apple/swift/issues/52190
   // let x1: Proto.Alias<String> = 0
   // let x2: Proto.OtherAlias<String> = 0
 

test/TypeRoundTrip/Inputs/testcases/structural_types.swift

@@ -49,8 +49,9 @@ public func test() {
   roundTripType(Array<(@escaping @convention(block) () -> (), @convention(block) () -> ()) -> ()>.Type.self)
   #endif
 
-  // rdar://81587763: [SR-15025]: Function type syntax doesn't accept variadics
-  // or __owned
+  // rdar://81587763
+  // https://github.com/apple/swift/issues/57353
+  // Function type syntax doesn't accept variadics or __owned
   //
   //roundTripType(((__owned String) -> ()).self)
   //roundTripType(((__owned String) -> ()).Type.self)

test/stmt/errors.swift

@@ -174,95 +174,79 @@ func thirteen() {
   }
 }
 
-// SR 6400
-
-enum SR_6400_E: Error {
-  case castError
-}
+// https://github.com/apple/swift/issues/48950
+protocol ClassProto: AnyObject {}
+do {
+  enum E: Error {
+    case castError
+  }
 
-struct SR_6400_S_1 {}
-struct SR_6400_S_2: Error {}
+  do {
+    struct S1 {}
+    struct S2: Error {}
 
-protocol SR_6400_FakeApplicationDelegate: AnyObject {}
-class SR_6400_FakeViewController {}
+    do {
+      throw E.castError
+    } catch is S1 {} // expected-warning {{cast from 'any Error' to unrelated type 'S1' always fails}}
 
-func sr_6400() throws {
-  do {
-    throw SR_6400_E.castError
-  } catch is SR_6400_S_1 { // expected-warning {{cast from 'any Error' to unrelated type 'SR_6400_S_1' always fails}}
-    print("Caught error")
-  }
-  
-  do {
-    throw SR_6400_E.castError
-  } catch is SR_6400_S_2 {
-    print("Caught error") // Ok
+    do {
+      throw E.castError
+    } catch is S2 {} // Ok
   }
-}
 
-func sr_6400_1<T>(error: Error, as type: T.Type) -> Bool {
-  return (error as? T) != nil // Ok
-}
-
-func sr_6400_2(error: Error) {
-  _ = error as? (SR_6400_FakeViewController & Error) // Ok
-}
-func sr_6400_3(error: Error) {
-  _ = error as? (Error & SR_6400_FakeApplicationDelegate) // Ok
-}
+  do {
+    class C1 {}
+    class C2: ClassProto & Error {}
 
-class SR_6400_A {}
-class SR_6400_B: SR_6400_FakeApplicationDelegate & Error {}
+    do {
+      throw E.castError
+    } catch let error as C1 { // Okay
+      print(error)
+    } catch {}
 
-func sr_6400_4() {
-  do {
-    throw SR_6400_E.castError
-  } catch let error as SR_6400_A { // Okay
-    print(error)
-  } catch {
-    print("Bar")
+    do {
+      throw E.castError
+    } catch let error as C2 { // Okay
+      print(error)
+    } catch {}
+
+    let err: Error
+    _ = err as? (C1 & Error) // Ok
+    _ = err as? (Error & ClassProto) // Ok
   }
-  
-  do {
-    throw SR_6400_E.castError
-  } catch let error as SR_6400_B { // Okay
-    print(error)
-  } catch {
-    print("Bar")
+
+  func f<T>(error: Error, as type: T.Type) -> Bool {
+    return (error as? T) != nil // Ok
   }
 }
 
-// SR-11402
+// https://github.com/apple/swift/issues/53803
+protocol P {}
+do {
+  class Super {}
+  class Sub: Super, P {}
+  final class Final {}
 
-protocol SR_11402_P {}
-class SR_11402_Superclass {}
-class SR_11402_Subclass: SR_11402_Superclass, SR_11402_P {}
+  let x: any P
 
-func sr_11402_func1(_ x: SR_11402_P) {
-  if let y = x as? SR_11402_Superclass { // Okay
-    print(y)
-  }
-}
-
-final class SR_11402_Final {}
+  if let _ = x as? Super {} // Okay
 
-func sr_11402_func2(_ x: SR_11402_P) {
-  if let y = x as? SR_11402_Final { // expected-warning {{cast from 'any SR_11402_P' to unrelated type 'SR_11402_Final' always fails}}
-    print(y)
-  }
+  if let _ = x as? Final {} // expected-warning {{cast from 'any P' to unrelated type 'Final' always fails}}
 }
 
-// https://bugs.swift.org/browse/SR-13654
+// https://github.com/apple/swift/issues/56091
+do {
+  func f() throws -> String {}
 
-func sr_13654_func() throws -> String {}
+  func invalid_interpolation() {
+    _ = try "\(f())" // expected-error {{errors thrown from here are not handled}}
+    _ = "\(try f())" // expected-error {{errors thrown from here are not handled}}
+  }
 
-func sr_13654_invalid_interpolation() {
-  _ = try "\(sr_13654_func())" // expected-error {{errors thrown from here are not handled}}
-  _ = "\(try sr_13654_func())" // expected-error {{errors thrown from here are not handled}}
-}
-func sr_13654_valid_interpolation() throws {
-  _ = try "\(sr_13654_func())"
-  _ = "\(try sr_13654_func())"
+  func valid_interpolation() throws {
+    _ = try "\(f())"
+    _ = "\(try f())"
+  }
 }
 
 // rdar://problem/72748150

test/stmt/foreach.swift

@@ -227,8 +227,12 @@ func testRepeated(ri: RepeatedSequence<Int>) {
   for x in ri { _ = x }
 }
 
-// SR-12398: Poor pattern matching diagnostic: "for-in loop requires '[Int]' to conform to 'Sequence'"
-func sr_12398(arr1: [Int], arr2: [(a: Int, b: String)]) {
+// https://github.com/apple/swift/issues/54836
+// Poor pattern matching diagnostic: for-in loop requires '[Int]' to conform to 'Sequence'
+do {
+  let arr1: [Int]
+  let arr2: [(a: Int, b: String)]
+
   for (x, y) in arr1 {}
   // expected-error@-1 {{tuple pattern cannot match values of non-tuple type 'Int'}}
 
@@ -245,7 +249,8 @@ func testForEachWhereWithClosure(_ x: [Int]) {
   for i in x where x.contains(where: { $0.byteSwapped == i }) {}
 }
 
-// https://github.com/apple/swift/issues/59522 - use of `prefix` with generic base causes ambiguity in for-in statement
+// https://github.com/apple/swift/issues/59522
+// Use of 'prefix' with generic base causes ambiguity in for-in statement
 func test_no_ambiguity_with_prefix_iterator<C: Collection>(c: C) {
   for _ in c.prefix(1) { // Ok
   }

test/stmt/if_while_var.swift

@@ -291,7 +291,8 @@ class UsesPayload {
   }
 }
 
-func sr_13258() {
+// https://github.com/apple/swift/issues/55698
+do {
   let a = 1
   let b = Int?.none
   if let c = b ?? a { _ = c } // expected-error {{initializer for conditional binding must have Optional type, not 'Int'}}

test/stmt/statements.swift

@@ -381,7 +381,7 @@ func test_guard(_ x : Int, y : Int??, z: Int?, cond : Bool) {
 
   guard case _ = x else {}  // expected-warning {{'guard' condition is always true, body is unreachable}}
 
-  // SR-7567
+  // https://github.com/apple/swift/issues/50109
   guard let outer = y else {
     // FIXME: Bring back the tailored diagnostic
     guard true else {

test/stmt/yield.swift

@@ -93,7 +93,7 @@ struct YieldInDefer {
   }
 }
 
-// SR-15066
+// https://github.com/apple/swift/issues/57393
 struct InvalidYieldParsing {
   var property: String {
     _read {

test/type/array.swift

@@ -114,14 +114,15 @@ func passAssocType<T : HasAssocType>(_ t: T) {
   takesAssocType(t, [T.A](), [T.A?]())
 }
 
-// SR-11134
-
-let sr_11134_1 = [[1, 2, 3][0]] // ok
-let sr_11134_2 = [[1, 2, 3] [1]] // expected-warning {{unexpected subscript in array literal; did you mean to write two separate elements instead?}}
-// expected-note@-1 {{add a separator between the elements}}{{28-28=,}}
-// expected-note@-2 {{remove the space between the elements to silence this warning}}{{28-29=}}
-let sr_11134_3 = [
-  [1, 2, 3] [1] // expected-warning {{unexpected subscript in array literal; did you mean to write two separate elements instead?}}
-// expected-note@-1 {{add a separator between the elements}}{{12-12=,}}
-// expected-note@-2 {{remove the space between the elements to silence this warning}}{{12-13=}}
-]
+// https://github.com/apple/swift/issues/53530
+do {
+  let _ = [[1, 2, 3][0]] // ok
+  let _ = [[1, 2, 3] [1]] // expected-warning {{unexpected subscript in array literal; did you mean to write two separate elements instead?}}
+  // expected-note@-1 {{add a separator between the elements}}{{21-21=,}}
+  // expected-note@-2 {{remove the space between the elements to silence this warning}}{{21-22=}}
+  let _ = [
+    [1, 2, 3] [1] // expected-warning {{unexpected subscript in array literal; did you mean to write two separate elements instead?}}
+  // expected-note@-1 {{add a separator between the elements}}{{14-14=,}}
+  // expected-note@-2 {{remove the space between the elements to silence this warning}}{{14-15=}}
+  ]
+}

test/type/opaque.swift

@@ -537,12 +537,14 @@ func test_diagnostic_with_contextual_generic_params() {
   }
 }
 
-// SR-10988 - Suggest `return` when the last statement of a multi-statement function body would be a valid return value
+// https://github.com/apple/swift/issues/53378
+// Suggest `return` when the last statement of a multi-statement function body
+// would be a valid return value
 protocol P1 {
 }
 protocol P2 {
 }
-func sr10988() {
+do {
   func test() -> some Numeric {
     // expected-error@-1 {{function declares an opaque return type, but has no return statements in its body from which to infer an underlying type}}
     let x = 0