Merge pull request #77172 from Azoy/generic-concrete-hassymbol

[IRGen] Support generic but concrete metatypes with hasSymbol

Author: Azoy

lib/IRGen/GenHasSymbol.cpp

@@ -26,6 +26,7 @@
 #include "clang/AST/GlobalDecl.h"
 
 #include "GenDecl.h"
+#include "GenericArguments.h"
 #include "IRGenFunction.h"
 #include "IRGenModule.h"
 
@@ -36,9 +37,23 @@ using namespace irgen;
 /// additional types of entities that the main utility cannot.
 static llvm::Constant *getAddrOfLLVMVariable(IRGenModule &IGM,
                                              LinkEntity entity) {
-  if (entity.isTypeMetadataAccessFunction())
-    return IGM.getAddrOfTypeMetadataAccessFunction(entity.getType(),
-                                                   NotForDefinition);
+  if (entity.isTypeMetadataAccessFunction()) {
+    auto type = entity.getType();
+    auto nominal = type->getAnyNominal();
+    assert(nominal);
+
+    if (nominal->isGenericContext()) {
+      GenericArguments genericArgs;
+      genericArgs.collectTypes(IGM, nominal);
+
+      return IGM.getAddrOfGenericTypeMetadataAccessFunction(nominal,
+                                                            genericArgs.Types,
+                                                            NotForDefinition);
+    } else {
+      return IGM.getAddrOfTypeMetadataAccessFunction(type,
+                                                     NotForDefinition);
+    }
+  }
   if (entity.isDispatchThunk())
     return IGM.getAddrOfDispatchThunk(entity.getSILDeclRef(), NotForDefinition);
 

test/IRGen/Inputs/has_symbol/has_symbol_helper.swift

@@ -64,3 +64,5 @@ public actor A {
   public func asyncMethod() async {}
 }
 #endif
+
+public struct Generic<T> {}

test/IRGen/has_symbol.swift

@@ -165,8 +165,15 @@ public func testExistentialParameter(_ p: any P) {
 public func testMetatypes() {
   // CHECK: %{{[0-9]+}} = call i1 @"$s17has_symbol_helper1SVTwS"()
   if #_hasSymbol(S.self) {}
+
+  // CHECK: %{{[0-9]+}} = call i1 @"$s17has_symbol_helper7GenericVTwS"()
+  if #_hasSymbol(Generic<Void>.self) {}
 }
 
 // --- S.self ---
 // CHECK: define linkonce_odr hidden i1 @"$s17has_symbol_helper1SVTwS"()
 // CHECK:   ret i1 and (i1 and (i1 icmp ne (ptr @"$s17has_symbol_helper1SVMn", ptr null), i1 icmp ne (ptr @"$s17has_symbol_helper1SVN", ptr null)), i1 icmp ne (ptr @"$s17has_symbol_helper1SVMa", ptr null))
+
+// --- Generic<Void>.self ---
+// CHECK: define linkonce_odr hidden i1 @"$s17has_symbol_helper7GenericVTwS"()
+// CHECK:   ret i1 and (i1 icmp ne (ptr @"$s17has_symbol_helper7GenericVMn", ptr null), i1 icmp ne (ptr @"$s17has_symbol_helper7GenericVMa", ptr null))