Sema: Remove unnecessary parameter from getUnsatisfiedAvailabilityConstraint().

The `DeclContext` was unused.

Author: tshortli

lib/Sema/DerivedConformanceRawRepresentable.cpp

@@ -237,12 +237,12 @@ struct RuntimeVersionCheck {
 /// information about the runtime check needed to ensure it is available to
 /// \c versionCheck and returns true.
 static bool
-checkAvailability(const EnumElementDecl *elt, DeclContext *dc,
+checkAvailability(const EnumElementDecl *elt,
                   AvailabilityContext availabilityContext,
                   std::optional<RuntimeVersionCheck> &versionCheck) {
-  auto &C = dc->getASTContext();
+  auto &C = elt->getASTContext();
   auto constraint =
-      getUnsatisfiedAvailabilityConstraint(elt, dc, availabilityContext);
+      getUnsatisfiedAvailabilityConstraint(elt, availabilityContext);
 
   // Is it always available?
   if (!constraint)
@@ -316,7 +316,7 @@ deriveBodyRawRepresentable_init(AbstractFunctionDecl *initDecl, void *) {
     // information about that check in versionCheck and keep processing this
     // element.
     std::optional<RuntimeVersionCheck> versionCheck(std::nullopt);
-    if (!checkAvailability(elt, parentDC, availabilityContext, versionCheck))
+    if (!checkAvailability(elt, availabilityContext, versionCheck))
       continue;
 
     // litPat = elt.rawValueExpr as a pattern

lib/Sema/TypeCheckAvailability.cpp

@@ -3103,9 +3103,8 @@ bool diagnoseExplicitUnavailability(
 
 std::optional<AvailabilityConstraint>
 swift::getUnsatisfiedAvailabilityConstraint(
-    const Decl *decl, const DeclContext *declContext,
-    AvailabilityContext availabilityContext) {
-  auto &ctx = declContext->getASTContext();
+    const Decl *decl, AvailabilityContext availabilityContext) {
+  auto &ctx = decl->getASTContext();
 
   // Generic parameters are always available.
   if (isa<GenericTypeParamDecl>(decl))
@@ -3148,8 +3147,7 @@ swift::getUnsatisfiedAvailabilityConstraint(const Decl *decl,
                                             const DeclContext *referenceDC,
                                             SourceLoc referenceLoc) {
   return getUnsatisfiedAvailabilityConstraint(
-      decl, referenceDC,
-      TypeChecker::availabilityAtLocation(referenceLoc, referenceDC));
+      decl, TypeChecker::availabilityAtLocation(referenceLoc, referenceDC));
 }
 
 /// Check if this is a subscript declaration inside String or
@@ -4190,7 +4188,7 @@ bool swift::diagnoseDeclAvailability(const ValueDecl *D, SourceRange R,
   auto &ctx = DC->getASTContext();
 
   auto constraint =
-      getUnsatisfiedAvailabilityConstraint(D, DC, Where.getAvailability());
+      getUnsatisfiedAvailabilityConstraint(D, Where.getAvailability());
 
   if (constraint && !constraint->isConditionallySatisfiable()) {
     // FIXME: diagnoseExplicitUnavailability should take an unmet requirement
@@ -4699,8 +4697,8 @@ swift::diagnoseConformanceAvailability(SourceLoc loc,
       return true;
     }
 
-    auto constraint = getUnsatisfiedAvailabilityConstraint(
-        ext, where.getDeclContext(), where.getAvailability());
+    auto constraint =
+        getUnsatisfiedAvailabilityConstraint(ext, where.getAvailability());
     if (constraint) {
       // FIXME: diagnoseExplicitUnavailability() should take unmet requirement
       if (diagnoseExplicitUnavailability(

lib/Sema/TypeCheckAvailability.h

@@ -247,7 +247,6 @@ void diagnoseOverrideOfUnavailableDecl(ValueDecl *override,
 /// Returns `std::nullopt` if the declaration is available.
 std::optional<AvailabilityConstraint>
 getUnsatisfiedAvailabilityConstraint(const Decl *decl,
-                                     const DeclContext *declContext,
                                      AvailabilityContext availabilityContext);
 
 /// Checks whether a declaration should be considered unavailable when referred