Skip to content

Commit 95dfa3d

Browse files
authored
Merge pull request #83579 from etcwilde/ewilde/test-use-module-triple
Tests: Use variant module triple
2 parents d237e2e + 1f06214 commit 95dfa3d

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

test/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,7 @@ foreach(SDK ${SWIFT_SDKS})
382382
get_swift_test_variant_suffix(VARIANT_SUFFIX "${SDK}" "${ARCH}" "${BUILD_FLAVOR}")
383383
get_swift_test_variant_suffix(DEFAULT_OSX_VARIANT_SUFFIX "${SDK}" "${ARCH}" "default")
384384
get_swift_test_versioned_target_triple(VARIANT_TRIPLE "${SDK}" "${ARCH}" "${SWIFT_SDK_${SDK}_DEPLOYMENT_VERSION}" "${BUILD_FLAVOR}")
385+
set(VARIANT_MODULE_TRIPLE "${SWIFT_SDK_${SDK}_ARCH_${ARCH}_MODULE}")
385386

386387
# A directory where to put the xUnit-style XML test results.
387388
set(SWIFT_TEST_RESULTS_DIR

test/lit.cfg

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1274,7 +1274,7 @@ def use_interpreter_for_simple_runs():
12741274
config.target_run_simple_swiftgyb_parameterized = make_simple_target_run(gyb=True, parameterized=True)
12751275
config.available_features.add('interpret')
12761276

1277-
target_specific_module_triple = config.variant_triple
1277+
target_specific_module_triple = config.variant_module_triple
12781278
target_future = target_specific_module_triple
12791279

12801280
config.target_run = ''
@@ -1291,10 +1291,6 @@ config.target_clang_resource_dir_opt = ''
12911291
config.target_swift_default_executor_opt = '-lswift_ConcurrencyDefaultExecutor'
12921292

12931293
if run_vendor == 'apple':
1294-
target_specific_module_triple = '{}-apple-{}'.format(
1295-
{ 'aarch64': 'arm64', 'amd64': 'x86_64' }.get(run_cpu, run_cpu),
1296-
{ 'macosx': 'macos', 'darwin': 'macos' }.get(run_os, run_os)
1297-
)
12981294

12991295
config.target_object_format = "macho"
13001296
config.target_shared_library_prefix = 'lib'
@@ -1493,8 +1489,6 @@ if run_vendor == 'apple':
14931489
xcrun_sdk_name = "appletvsimulator"
14941490
target_future_version = "99.99.0"
14951491

1496-
target_specific_module_triple += "-simulator"
1497-
14981492
config.target_env_prefix = 'SIMCTL_CHILD_'
14991493

15001494
config.target_cc_options = (
@@ -3243,5 +3237,7 @@ visual_studio_version = os.environ.get('VisualStudioVersion')
32433237
if kIsWindows and visual_studio_version:
32443238
config.available_features.add('MSVC_VER=%s' % visual_studio_version)
32453239

3240+
lit_config.note(f"Target Triple: {config.target_triple}, Variant Triple: {config.variant_triple}, Module Triple: {config.variant_module_triple}")
3241+
32463242
lit_config.note("Available features: " + ", ".join(sorted(config.available_features)))
32473243
config.substitutions.append( ('%use_no_opaque_pointers', '-Xcc -Xclang -Xcc -no-opaque-pointers' ) )

test/lit.site.cfg.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ config.swift_src_root = lit_config.params.get("swift_src_root", "@SWIFT_SOURCE_D
2828
config.swift_obj_root = "@SWIFT_BINARY_DIR@"
2929
config.target_triple = "@LLVM_TARGET_TRIPLE@"
3030
config.variant_triple = "@VARIANT_TRIPLE@"
31+
config.variant_module_triple = "@VARIANT_MODULE_TRIPLE@"
3132
config.variant_sdk = "@VARIANT_SDK@"
3233
config.variant_suffix = "@VARIANT_SUFFIX@"
3334
config.external_embedded_platform = "@VARIANT_EXTERNAL_EMBEDDED_PLATFORM@" == "TRUE"

validation-test/lit.site.cfg.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ config.swift_src_root = "@SWIFT_SOURCE_DIR@"
2525
config.swift_obj_root = "@SWIFT_BINARY_DIR@"
2626
config.target_triple = "@LLVM_TARGET_TRIPLE@"
2727
config.variant_triple = "@VARIANT_TRIPLE@"
28+
config.variant_module_triple = "@VARIANT_MODULE_TRIPLE@"
2829
config.variant_suffix = "@VARIANT_SUFFIX@"
2930
config.variant_sdk = "@VARIANT_SDK@"
3031
config.swift_test_results_dir = \

0 commit comments

Comments
 (0)