Skip to content

Commit 9635ef5

Browse files
committed
Try to fix up availability of legacy shim functions
1 parent f8d9b52 commit 9635ef5

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

stdlib/public/core/FloatingPointToString.swift

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@
129129
// Float16 is not currently supported on Intel x86_64 macOS,
130130
// (including macCatalyst on x86_64) but this symbol somehow got
131131
// exported there.
132-
// This preserves the export.
132+
// This preserves that export.
133+
134+
// Note: Other platforms that don't support Float16 should
135+
// NOT export this.
133136
@available(SwiftStdlib 5.3, *)
134137
@_silgen_name("swift_float16ToString")
135138
public func _float16ToStringImpl(
@@ -439,7 +442,7 @@ internal func _Float16ToASCII(
439442
// Support Legacy ABI on top of new implementation
440443
@_silgen_name("swift_float32ToString")
441444
@usableFromInline
442-
func _float32ToStringImpl(
445+
private func _float32ToStringImpl(
443446
_ textBuffer: UnsafeMutablePointer<UTF8.CodeUnit>,
444447
_ bufferLength: UInt,
445448
_ value: Float32,
@@ -692,7 +695,7 @@ internal func _Float32ToASCII(
692695
// Support Legacy ABI on top of new implementation
693696
@_silgen_name("swift_float64ToString")
694697
@usableFromInline
695-
func _float64ToStringImpl(
698+
private func _float64ToStringImpl(
696699
_ textBuffer: UnsafeMutablePointer<UTF8.CodeUnit>,
697700
_ bufferLength: UInt,
698701
_ value: Float64,
@@ -1200,7 +1203,7 @@ internal func _Float64ToASCII(
12001203
// Support Legacy ABI on top of new implementation
12011204
@_silgen_name("swift_float80ToString")
12021205
@usableFromInline
1203-
func _float80ToStringImpl(
1206+
private func _float80ToStringImpl(
12041207
_ textBuffer: UnsafeMutablePointer<UTF8.CodeUnit>,
12051208
_ bufferLength: UInt,
12061209
_ value: Float80,

0 commit comments

Comments
 (0)