Skip to content

Commit 98e3ca8

Browse files
committed
Annotate some SourceKit tests that fail on Linux.
* A bunch of them require objc_interop because they import code containing Objective-C. * Many others fail on Ubuntu 14.04 because the C++ there doesn't have a functional std::regex implementation which is required by the `complete-test` tool. It may be possible to adjust some of these tests in the future to not need these extra requirements, but this is a straightforward way to clean up Linux test results for now.
1 parent f8a23da commit 98e3ca8

32 files changed

+41
-0
lines changed

test/SourceKit/CodeComplete/complete_cache.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import Foo
22

3+
// REQUIRES: objc_interop
34
// RUN: rm -rf %t.ccp
45
// RUN: %sourcekitd-test -req=complete.cache.ondisk -cache-path=%t.ccp == \
56
// RUN: -req=complete.open -pos=2:1 -req-opts=hidelowpriority=0 %s -- %s -F %S/../Inputs/libIDE-mock-sdk > %t.completions1

test/SourceKit/CodeComplete/complete_crash1.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// XFAIL: broken_std_regex
12
// RUN: %complete-test -tok=TOK1 -hide-none %s -- %s
23

34
import QuartzCore

test/SourceKit/CodeComplete/complete_filter.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ func foo() {
1111
x.#^FOO,,a,aa,ab,abc,abcd^#
1212
}
1313

14+
// XFAIL: broken_std_regex
1415
// RUN: %sourcekitd-test -req=complete.open -pos=11:5 %s -- %s > %t.all
1516
// FileCheck -check-prefix=CHECK-ALL %s < %t.all
1617
// CHECK-ALL: key.name: "aaa

test/SourceKit/CodeComplete/complete_filter_rules.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ struct TestHideName {
1010
func hideThis4(namedParam1 x: Int, namedParam2: Int) {}
1111
func dontHideThisByName() {}
1212

13+
// XFAIL: broken_std_regex
14+
1315
// RUN: %complete-test -filter-rules=%S/Inputs/filter-rules/hideNames.json -tok=HIDE_NAMES_1 %s -- -F %S/../Inputs/libIDE-mock-sdk | FileCheck %s -check-prefix=HIDE_NAMES
1416
func testHideName01() {
1517
#^HIDE_NAMES_1,hidethis^#

test/SourceKit/CodeComplete/complete_from_clang_module.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import Foo
22

3+
// REQUIRES: objc_interop
34
// RUN: %sourcekitd-test -req=complete -pos=2:1 %s -- %mcp_opt -F %S/../Inputs/libIDE-mock-sdk %s | FileCheck %s
45

56
// CHECK-LABEL: key.name: "fooIntVar",

test/SourceKit/CodeComplete/complete_fuzzy.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ func footastic() {}
99

1010
// ===- Without a filter, we group.
1111

12+
// XFAIL: broken_std_regex
13+
1214
// RUN: %complete-test %s -group=stems -tok=TOP_LEVEL_NO_FILTER | FileCheck %s -check-prefix=TOP_LEVEL_NO_FILTER
1315
// RUN: %complete-test %s -group=stems -fuzz -tok=TOP_LEVEL_NO_FILTER | FileCheck %s -check-prefix=TOP_LEVEL_NO_FILTER
1416
func test1() {

test/SourceKit/CodeComplete/complete_group_overloads.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// XFAIL: broken_std_regex
2+
13
struct A {}
24
struct B {}
35

test/SourceKit/CodeComplete/complete_hide_low_priority.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// XFAIL: broken_std_regex
12
// RUN: %complete-test -hide-low-priority=1 -tok=TOP_LEVEL_0 %s -- -I %S/Inputs > %t.on
23
// RUN: %complete-test -hide-low-priority=0 -tok=TOP_LEVEL_0 %s -- -I %S/Inputs > %t.off
34

test/SourceKit/CodeComplete/complete_import_module_flag.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// XFAIL: broken_std_regex
12
// RUN: mkdir -p %t
23
// RUN: %swift -Xcc -I%S/Inputs -emit-module -o %t/auxiliary_file.swiftmodule %S/Inputs/auxiliary_file.swift
34
// RUN: %complete-test -group=none -hide-none -raw -tok=TOP_LEVEL_0 %s -- -import-module auxiliary_file -I %t -I %S/Inputs | FileCheck %s

test/SourceKit/CodeComplete/complete_inner.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// XFAIL: broken_std_regex
2+
13
class Foo {}
24
class Base {
35
init() {}

0 commit comments

Comments
 (0)