[embedded] Tweak diagnostic message about metatypes in embedded Swift

Author: kubamracek

include/swift/AST/DiagnosticsSIL.def

@@ -357,7 +357,7 @@ ERROR(embedded_swift_existential_type,none,
 ERROR(embedded_swift_existential,none,
       "cannot use a value of protocol type in embedded Swift", ())
 ERROR(embedded_swift_metatype_type,none,
-      "cannot use metatype %0 in embedded Swift", (Type))
+      "cannot use metatype of type %0 in embedded Swift", (Type))
 ERROR(embedded_swift_metatype,none,
       "cannot use metatype in embedded Swift", ())
 NOTE(performance_called_from,none,

test/embedded/metatypes.swift

@@ -8,7 +8,7 @@ public func sink<T>(t: T) {}
 
 public func test() -> Int {
   let metatype = Int.self
-  sink(t: metatype) // expected-error {{cannot use metatype 'Int' in embedded Swift}}
+  sink(t: metatype) // expected-error {{cannot use metatype of type 'Int' in embedded Swift}}
   // expected-note@-1 {{called from here}}
   return 42
 }

test/embedded/typeof.swift

@@ -6,7 +6,7 @@
 
 public func unsafeWriteArray<T, R>(_ elementType: R.Type, array: inout T, index n: Int, value: R) {
   precondition(_isPOD(elementType))
-  precondition(_isPOD(type(of: array))) // expected-error {{cannot use metatype '(Int, Int, Int, Int)' in embedded Swift}}
+  precondition(_isPOD(type(of: array))) // expected-error {{cannot use metatype of type '(Int, Int, Int, Int)' in embedded Swift}}
   // expected-note@-1 {{called from here}}
 
   return withUnsafeMutableBytes(of: &array) { ptr in