[libSyntax] Remove unnecessary getOpaqueNode and takeOpaqueNode from ParsedRawSyntaxNode

They are superseded by getData/takeData

Author: ahoppen

include/swift/Parse/ParsedRawSyntaxNode.h

@@ -163,19 +163,6 @@ class ParsedRawSyntaxNode {
   /// Returns the range of this node including leading and trailing trivia.
   CharSourceRange getRange() const { return Range; }
 
-  // Recorded Data ===========================================================//
-
-  OpaqueSyntaxNode getOpaqueNode() const {
-    assert(isRecorded());
-    return Data.getOpaque();
-  }
-  OpaqueSyntaxNode takeOpaqueNode() {
-    assert(isRecorded());
-    auto opaque = Data.getOpaque();
-    reset();
-    return opaque;
-  }
-
   // Deferred Layout Data ====================================================//
 
   /// If this node is a deferred layout node, return the child at index \p

lib/Parse/SyntaxParsingContext.cpp

@@ -329,7 +329,8 @@ OpaqueSyntaxNode SyntaxParsingContext::finalizeRoot() {
   // the root context.
   getStorage().clear();
 
-  return root.takeOpaqueNode();
+  assert(root.isRecorded() && "Root of syntax tree should be recorded");
+  return root.takeData();
 }
 
 void SyntaxParsingContext::synthesize(tok Kind, SourceLoc Loc) {