Merge pull request #71767 from aschwaighofer/large_types_reg2mem_c_signature

LargeTypesReg2Mem: Remove overzealous assert

Author: aschwaighofer

lib/IRGen/LoadableByAddress.cpp

@@ -4245,11 +4245,7 @@ static void runPeepholesAndReg2Mem(SILPassManager *pm, SILModule *silMod,
       if (&bb == entryBB) {
         for (auto *arg : bb.getArguments()) {
           auto ty = arg->getType();
-          // This is an idiosyncrasy of the large loadable types pass which
-          // ignores tuple types (considers them always "small").
           if (assignment.isLargeLoadableType(ty)) {
-            assert(isa<TupleType>(ty.getASTType()));
-            ;
             auto addr = assignment.createAllocStack(ty);
             assignment.mapValueToAddress(arg, addr);
             // We will emit the store to initialize after parsing all other

test/IRGen/Inputs/large_c.h

@@ -0,0 +1,31 @@
+#pragma once
+
+struct SamplesType {
+    void* A;
+    void* B;
+    void* C;
+    void* D;
+    void* E;
+    void* F;
+    void* G;
+    void* H;
+    void* I;
+    void* J;
+    void* K;
+    void* L;
+    void* M;
+    void* N;
+    void* O;
+    void* P;
+    void* Q;
+    void* R;
+    void* S;
+    void* T;
+    void* U;
+    void* V;
+    void* W;
+    void* X;
+    void* Y;
+    void* Z;
+    void* AA;
+};

test/IRGen/loadable_by_address_reg2mem.sil

@@ -1,4 +1,4 @@
-// RUN: %target-swift-frontend %s  -Xllvm -sil-print-after=loadable-address -c -o %t/t.o 2>&1 | %FileCheck %s
+// RUN: %target-swift-frontend %s  -Xllvm -sil-print-after=loadable-address -import-objc-header %S/Inputs/large_c.h -c -o %t/t.o 2>&1 | %FileCheck %s
 
 sil_stage canonical
 
@@ -215,3 +215,17 @@ bb0(%0 : $*Y):
   %t = tuple ()
   return %t : $()
 }
+
+// CHECK: sil @test8
+// CHECK: bb0(%0 : $SamplesType):
+// CHECK:   %1 = alloc_stack $SamplesType
+// CHECK:   store %0 to %1 : $*SamplesType
+sil @helper : $@convention(thin) (SamplesType) -> ()
+
+sil @test8 : $@convention(c) (SamplesType) -> () {
+bb0(%0 : $SamplesType):
+  %1 = function_ref @helper : $@convention(thin) (SamplesType) -> ()
+  %2 = apply %1(%0) : $@convention(thin) (SamplesType) -> ()
+  %t = tuple ()
+  return %t : $()
+}