Merge pull request #60786 from zoecarver/unavailable-attr-class-templates

zoecarver · web-flow · commit ac131dfbf612 · 2022-10-26T11:07:56.000-07:00
[cxx-interop] Mark un-specialized class templates as unavailable in Swift.
diff --git a/SwiftCompilerSources/Sources/AST/DiagnosticEngine.swift b/SwiftCompilerSources/Sources/AST/DiagnosticEngine.swift
@@ -46,7 +46,7 @@ public struct DiagnosticFixIt {
       let bridgedDiagnosticFixIt = swift.DiagnosticInfo.FixIt(
         swift.CharSourceRange(start.bridged, UInt32(byteLength)),
         bridgedTextRef,
-        llvm.ArrayRef<swift.DiagnosticArgument>())
+        ArrayRefOfDiagnosticArgument())
       fn(bridgedDiagnosticFixIt)
     }
   }
diff --git a/include/swift/AST/ASTBridging.h b/include/swift/AST/ASTBridging.h
@@ -38,6 +38,8 @@ void DiagnosticEngine_diagnose(swift::DiagnosticEngine &, swift::SourceLoc loc,
                                swift::CharSourceRange highlight,
                                BridgedArrayRef fixIts);
 
+using ArrayRefOfDiagnosticArgument = llvm::ArrayRef<swift::DiagnosticArgument>;
+
 SWIFT_END_NULLABILITY_ANNOTATIONS
 
 #endif // SWIFT_AST_ASTBRIDGING_H
diff --git a/lib/ClangImporter/ImportDecl.cpp b/lib/ClangImporter/ImportDecl.cpp
@@ -3497,6 +3497,13 @@ namespace {
 
       auto structDecl = Impl.createDeclWithClangNode<StructDecl>(
         decl, AccessLevel::Public, loc, name, loc, None, genericParamList, dc);
+
+      auto attr = AvailableAttr::createPlatformAgnostic(
+          Impl.SwiftContext, "Un-specialized class templates are not currently "
+                             "supported. Please use a specialization of this "
+                             "type.");
+      structDecl->getAttrs().add(attr);
+
       return structDecl;
     }
 
diff --git a/test/Interop/Cxx/namespace/templates-module-interface.swift b/test/Interop/Cxx/namespace/templates-module-interface.swift
@@ -7,13 +7,15 @@
 // CHECK-NEXT:       init()
 // CHECK-NEXT:       mutating func basicMember() -> UnsafePointer<CChar>!
 // CHECK-NEXT:     }
+// CHECK-NEXT:     @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:     struct ForwardDeclaredClassTemplate<> {
 // CHECK-NEXT:     }
 // CHECK-NEXT:     static func forwardDeclaredFunctionTemplateOutOfLine<T>(_: T) -> UnsafePointer<CChar>!
 // CHECK-NEXT:     struct __CxxTemplateInstN12TemplatesNS112TemplatesNS237ForwardDeclaredClassTemplateOutOfLineIcEE {
 // CHECK-NEXT:       init()
 // CHECK-NEXT:       mutating func basicMember() -> UnsafePointer<CChar>!
 // CHECK-NEXT:     }
+// CHECK-NEXT:     @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:     struct ForwardDeclaredClassTemplateOutOfLine<> {
 // CHECK-NEXT:     }
 // CHECK-NEXT:     typealias BasicClassTemplateChar = TemplatesNS1.TemplatesNS3.__CxxTemplateInstN12TemplatesNS112TemplatesNS318BasicClassTemplateIcEE
@@ -24,10 +26,12 @@
 // CHECK-NEXT:     init()
 // CHECK-NEXT:     mutating func basicMember() -> UnsafePointer<CChar>!
 // CHECK-NEXT:   }
+// CHECK-NEXT:   @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:   struct BasicClassTemplate<> {
 // CHECK-NEXT:   }
 // CHECK-NEXT:   typealias BasicClassTemplateChar = TemplatesNS1.__CxxTemplateInstN12TemplatesNS118BasicClassTemplateIcEE
 // CHECK-NEXT:   static func basicFunctionTemplateDefinedInDefs<T>(_: T) -> UnsafePointer<CChar>!
+// CHECK-NEXT:   @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:   struct BasicClassTemplateDefinedInDefs<> {
 // CHECK-NEXT:   }
 // CHECK-NEXT:   typealias UseTemplate = TemplatesNS4.__CxxTemplateInstN12TemplatesNS417HasSpecializationIcEE
@@ -36,6 +40,7 @@
 // CHECK-NEXT:     struct __CxxTemplateInstN12TemplatesNS112TemplatesNS318BasicClassTemplateIcEE {
 // CHECK-NEXT:       init()
 // CHECK-NEXT:     }
+// CHECK-NEXT:     @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:     struct BasicClassTemplate<> {
 // CHECK-NEXT:     }
 // CHECK-NEXT:   }
@@ -53,6 +58,7 @@
 // CHECK-NEXT:   struct __CxxTemplateInstN12TemplatesNS417HasSpecializationIiEE {
 // CHECK-NEXT:     init()
 // CHECK-NEXT:   }
+// CHECK-NEXT:   @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:   struct HasSpecialization<> {
 // CHECK-NEXT:   }
 // CHECK-NEXT: }
diff --git a/test/Interop/Cxx/namespace/templates-with-forward-decl-module-interface.swift b/test/Interop/Cxx/namespace/templates-with-forward-decl-module-interface.swift
@@ -4,6 +4,7 @@
 // CHECK-NEXT:   struct __CxxTemplateInstN3NS115ForwardDeclaredIiEE {
 // CHECK-NEXT:     init()
 // CHECK-NEXT:   }
+// CHECK-NEXT:   @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:   struct ForwardDeclared<T> {
 // CHECK-NEXT:   }
 // CHECK-NEXT:   struct __CxxTemplateInstN3NS14DeclIiEE {
@@ -13,6 +14,7 @@
 // CHECK-NEXT:     var fwd: NS1.__CxxTemplateInstN3NS115ForwardDeclaredIiEE
 // CHECK-NEXT:     static let intValue: NS1.__CxxTemplateInstN3NS14DeclIiEE.MyInt
 // CHECK-NEXT:   }
+// CHECK-NEXT:   @available(*, unavailable, message: "Un-specialized class templates are not currently supported. Please use a specialization of this type.")
 // CHECK-NEXT:   struct Decl<T> {
 // CHECK-NEXT:   }
 // CHECK-NEXT:   typealias di = NS1.__CxxTemplateInstN3NS14DeclIiEE
diff --git a/test/Interop/Cxx/templates/Inputs/SwiftClassInstantiationModule.swift b/test/Interop/Cxx/templates/Inputs/SwiftClassInstantiationModule.swift
@@ -1,10 +1,10 @@
 import ClassTemplateForSwiftModule
 
-public func makeWrappedMagicNumber() -> MagicWrapper<IntWrapper> {
+public func makeWrappedMagicNumber() -> MagicWrapperSpec {
   let t = IntWrapper(value: 42)
   return MagicWrapper<IntWrapper>(t: t)
 }
 
-public func readWrappedMagicNumber(_ i: inout MagicWrapper<IntWrapper>) -> CInt {
+public func readWrappedMagicNumber(_ i: inout MagicWrapperSpec) -> CInt {
   return i.getValuePlusArg(13)
 }
diff --git a/test/Interop/Cxx/templates/Inputs/class-template-for-swift-module.h b/test/Interop/Cxx/templates/Inputs/class-template-for-swift-module.h
@@ -12,4 +12,6 @@ struct MagicWrapper {
   int getValuePlusArg(int arg) const { return t.getValue() + arg; }
 };
 
+using MagicWrapperSpec = MagicWrapper<IntWrapper>;
+
 #endif // TEST_INTEROP_CXX_TEMPLATES_INPUTS_CLASS_TEMPLATE_FOR_SWIFT_MODULE_H
diff --git a/test/Interop/Cxx/templates/class-template-instantiation-existing-specialization.swift b/test/Interop/Cxx/templates/class-template-instantiation-existing-specialization.swift
@@ -1,4 +1,4 @@
-// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop)
+// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xfrontend -disable-availability-checking)
 //
 // REQUIRES: executable_test
 
diff --git a/test/Interop/Cxx/templates/class-template-instantiation-typechecker-calls-method-with-error.swift b/test/Interop/Cxx/templates/class-template-instantiation-typechecker-calls-method-with-error.swift
@@ -1,4 +1,4 @@
-// RUN: not %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop 2>&1 | %FileCheck %s
+// RUN: not %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop -disable-availability-checking 2>&1 | %FileCheck %s
 
 import ClassTemplateInstantiationErrors
 
diff --git a/test/Interop/Cxx/templates/class-template-instantiation-typechecker-constructor-calls-method-with-error.swift b/test/Interop/Cxx/templates/class-template-instantiation-typechecker-constructor-calls-method-with-error.swift
@@ -1,4 +1,4 @@
-// RUN: not %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop 2>&1 | %FileCheck %s
+// RUN: not %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop -disable-availability-checking 2>&1 | %FileCheck %s
 
 import ClassTemplateInstantiationErrors
 
diff --git a/test/Interop/Cxx/templates/class-template-instantiation.swift b/test/Interop/Cxx/templates/class-template-instantiation.swift
@@ -1,4 +1,4 @@
-// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop)
+// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xfrontend -disable-availability-checking)
 //
 // REQUIRES: executable_test
 
diff --git a/test/Interop/Cxx/templates/class-template-uninstantiatable-members-irgen.swift b/test/Interop/Cxx/templates/class-template-uninstantiatable-members-irgen.swift
@@ -1,4 +1,4 @@
-// RUN: %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop | %FileCheck %s
+// RUN: %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop -disable-availability-checking | %FileCheck %s
 
 import ClassTemplateInstantiationErrors
 
diff --git a/test/Interop/Cxx/templates/class-template-uninstantiatable-members.swift b/test/Interop/Cxx/templates/class-template-uninstantiatable-members.swift
@@ -1,4 +1,4 @@
-// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop)
+// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xfrontend -disable-availability-checking)
 //
 // REQUIRES: executable_test
 
diff --git a/test/Interop/Cxx/templates/define-referenced-inline.swift b/test/Interop/Cxx/templates/define-referenced-inline.swift
@@ -1,4 +1,4 @@
-// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xcc -fno-exceptions)
+// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xcc -fno-exceptions -Xfrontend -disable-availability-checking)
 //
 // REQUIRES: executable_test
 
diff --git a/test/Interop/Cxx/templates/dependent-types-silgen.swift b/test/Interop/Cxx/templates/dependent-types-silgen.swift
@@ -1,4 +1,4 @@
-// RUN: %target-swift-emit-silgen %s -I %S/Inputs -enable-experimental-cxx-interop | %FileCheck %s
+// RUN: %target-swift-emit-silgen %s -I %S/Inputs -enable-experimental-cxx-interop -disable-availability-checking | %FileCheck %s
 
 import DependentTypes
 
diff --git a/test/Interop/Cxx/templates/dependent-types.swift b/test/Interop/Cxx/templates/dependent-types.swift
@@ -1,4 +1,4 @@
-// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xfrontend -validate-tbd-against-ir=none)
+// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xfrontend -validate-tbd-against-ir=none -Xfrontend -disable-availability-checking)
 //
 // REQUIRES: executable_test
 //
diff --git a/test/Interop/Cxx/templates/swift-class-instantiation-module-interface.swift b/test/Interop/Cxx/templates/swift-class-instantiation-module-interface.swift
@@ -1,5 +1,5 @@
 // RUN: %empty-directory(%t)
-// RUN: %target-swiftxx-frontend -emit-module -o %t/SwiftClassTemplateModule.swiftmodule %S/Inputs/SwiftClassInstantiationModule.swift -I %S/Inputs -enable-library-evolution -swift-version 5
+// RUN: %target-swiftxx-frontend -emit-module -o %t/SwiftClassTemplateModule.swiftmodule %S/Inputs/SwiftClassInstantiationModule.swift -I %S/Inputs -enable-library-evolution -swift-version 5 -disable-availability-checking
 // RUN: %target-swift-ide-test -print-module -module-to-print=SwiftClassTemplateModule -I %t/ -source-filename=x -enable-experimental-cxx-interop | %FileCheck %s
 
 
diff --git a/test/Interop/CxxToSwiftToCxx/bridge-cxx-struct-back-to-cxx-execution.cpp b/test/Interop/CxxToSwiftToCxx/bridge-cxx-struct-back-to-cxx-execution.cpp
@@ -1,3 +1,6 @@
+// rdar://101431096
+// XFAIL: *
+
 // RUN: %empty-directory(%t)
 // RUN: split-file %s %t
 
diff --git a/test/Interop/CxxToSwiftToCxx/bridge-cxx-struct-back-to-cxx.swift b/test/Interop/CxxToSwiftToCxx/bridge-cxx-struct-back-to-cxx.swift
@@ -1,3 +1,6 @@
+// rdar://101431096
+// XFAIL: *
+
 // RUN: %empty-directory(%t)
 // RUN: split-file %s %t
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public struct DiagnosticFixIt {`
`46`	`46`	`let bridgedDiagnosticFixIt = swift.DiagnosticInfo.FixIt(`
`47`	`47`	`swift.CharSourceRange(start.bridged, UInt32(byteLength)),`
`48`	`48`	`bridgedTextRef,`
`49`		`- llvm.ArrayRef<swift.DiagnosticArgument>())`
	`49`	`+ ArrayRefOfDiagnosticArgument())`
`50`	`50`	`fn(bridgedDiagnosticFixIt)`
`51`	`51`	`}`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`	`1`	`import ClassTemplateForSwiftModule`
`2`	`2`
`3`		`-public func makeWrappedMagicNumber() -> MagicWrapper<IntWrapper> {`
	`3`	`+public func makeWrappedMagicNumber() -> MagicWrapperSpec {`
`4`	`4`	`let t = IntWrapper(value: 42)`
`5`	`5`	`return MagicWrapper<IntWrapper>(t: t)`
`6`	`6`	`}`
`7`	`7`
`8`		`-public func readWrappedMagicNumber(_ i: inout MagicWrapper<IntWrapper>) -> CInt {`
	`8`	`+public func readWrappedMagicNumber(_ i: inout MagicWrapperSpec) -> CInt {`
`9`	`9`	`return i.getValuePlusArg(13)`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop)`
	`1`	`+// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xfrontend -disable-availability-checking)`
`2`	`2`	`//`
`3`	`3`	`// REQUIRES: executable_test`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// RUN: not %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop 2>&1 \| %FileCheck %s`
	`1`	`+// RUN: not %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop -disable-availability-checking 2>&1 \| %FileCheck %s`
`2`	`2`
`3`	`3`	`import ClassTemplateInstantiationErrors`
`4`	`4`