Skip to content

Commit b09b622

Browse files
Merge pull request #82358 from AnthonyLatsis/no-warnings-asserts
[presets] Actually make #81284 work
2 parents 354efbd + e99f3e8 commit b09b622

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -824,6 +824,9 @@ elseif(UNIX)
824824
include(UnixCompileRules)
825825
endif()
826826

827+
# Add any extra C++ compilation options that were passed down.
828+
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:${SWIFT_EXTRA_CXX_FLAGS}>)
829+
827830
if(CMAKE_C_COMPILER_ID MATCHES Clang)
828831
add_compile_options($<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:-Werror=gnu>)
829832
endif()

utils/build-presets.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ enable-new-runtime-build
681681

682682
# Escalate certain C++ warnings to errors for Swift.
683683
extra-swift-cmake-options=
684-
-DCMAKE_CXX_FLAGS="-Werror=unused"
684+
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused"
685685

686686
[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto]
687687
mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx

0 commit comments

Comments
 (0)