[Sema] Diagnose passing integer to non-integer type parameter

This was previously missed, though would have been diagnosed later
as a requirement failure.

Author: hamishknight

lib/Sema/TypeCheckType.cpp

@@ -793,6 +793,9 @@ namespace {
         return false;
       }
 
+      if (secondType->is<IntegerType>())
+        return false;
+
       return true;
     }
 

test/Sema/inlinearray.swift

@@ -9,6 +9,8 @@ let e: InlineArray<2, _> = [1] // expected-error {{expected '2' elements in inli
 
 let f: InlineArray<_, Int> = ["hello"] // expected-error {{cannot convert value of type 'String' to expected element type 'Int'}}
 
+let g: InlineArray<1, 1> // expected-error {{cannot use value type '1' for generic argument 'Element'}}
+
 func takeVectorOf2<T>(_: InlineArray<2, T>) {}
 
 takeVectorOf2([1, 2]) // Ok

test/Sema/value_generics.swift

@@ -66,7 +66,9 @@ func h(_: (Int, 123)) {} // expected-error {{expected type}}
 func i(_: () -> 123) {} // expected-error {{expected type}}
 func j(_: (A<123>) -> ()) {} // OK
 func k(_: some 123) {} // expected-error {{expected parameter type following ':'}}
-func l(_: GenericWithIntParam<123, Int>) {} // expected-error {{cannot pass type 'Int' as a value for generic value 'N'}}
+func l(_: GenericWithIntParam<123, Int>) {}
+// expected-error@-1 {{cannot pass type 'Int' as a value for generic value 'N'}}
+// expected-error@-2 {{cannot use value type '123' for generic argument 'T'}}
 func m(_: GenericWithIntParam<Int, 123>) {} // OK
 
 typealias One = 1 // expected-error {{expected type in type alias declaration}}