Merge pull request #64118 from etcwilde/ewilde/pretty-colors

Enable swift color diagnostics in stdlib

Author: etcwilde

stdlib/cmake/modules/SwiftSource.cmake

@@ -131,6 +131,7 @@ function(handle_swift_sources
         list(APPEND swift_compile_flags "${_lto_flag_out}")
       endif()
     endif()
+    list(APPEND swift_compile_flags "-color-diagnostics")
     _compile_swift_files(
         dependency_target
         module_dependency_target

stdlib/public/Concurrency/AsyncStreamBuffer.swift

@@ -112,7 +112,7 @@ extension AsyncStream {
       let handler = state.onTermination
       state.onTermination = nil
       unlock()
-      
+
       // handler must be invoked before yielding nil for termination
       handler?(.cancelled)
 
@@ -124,7 +124,7 @@ extension AsyncStream {
       lock()
       let limit = state.limit
       let count = state.pending.count
-      
+
       if !state.continuations.isEmpty {
         let continuation = state.continuations.removeFirst()
         if count > 0 {
@@ -170,7 +170,7 @@ extension AsyncStream {
           case .bufferingOldest(let limit):
             result = .enqueued(remaining: limit)
           }
-          
+
           unlock()
           continuation.resume(returning: value)
         }
@@ -205,7 +205,7 @@ extension AsyncStream {
       }
       return result
     }
-    
+
     func finish() {
       lock()
       let handler = state.onTermination
@@ -249,9 +249,9 @@ extension AsyncStream {
       } else {
         unlock()
       }
-      
+
     }
-    
+
     func next() async -> Element? {
       await withTaskCancellationHandler { [cancel] in
         cancel()
@@ -289,7 +289,7 @@ extension AsyncThrowingStream {
       case finished
       case failed(Failure)
     }
-    
+
     struct State {
       var continuation: UnsafeContinuation<Element?, Error>?
       var pending = _Deque<Element>()
@@ -345,7 +345,7 @@ extension AsyncThrowingStream {
       let handler = state.onTermination
       state.onTermination = nil
       unlock()
-      
+
       // handler must be invoked before yielding nil for termination
       handler?(.cancelled)
 
@@ -409,7 +409,7 @@ extension AsyncThrowingStream {
           case .bufferingNewest(let limit):
             result = .enqueued(remaining: limit)
           }
-          
+
           state.continuation = nil
           unlock()
           continuation.resume(returning: value)
@@ -445,7 +445,7 @@ extension AsyncThrowingStream {
       }
       return result
     }
-    
+
     func finish(throwing error: __owned Failure? = nil) {
       lock()
       let handler = state.onTermination
@@ -510,7 +510,7 @@ extension AsyncThrowingStream {
         fatalError("attempt to await next() on more than one task")
       }
     }
-    
+
     func next() async throws -> Element? {
       try await withTaskCancellationHandler { [cancel] in
         cancel()
@@ -546,7 +546,7 @@ final class _AsyncStreamCriticalStorage<Contents>: @unchecked Sendable {
   private init(_doNotCallMe: ()) {
     fatalError("_AsyncStreamCriticalStorage must be initialized by create")
   }
-  
+
   private func lock() {
     let ptr =
       UnsafeRawPointer(Builtin.projectTailElems(self, UnsafeRawPointer.self))
@@ -558,15 +558,15 @@ final class _AsyncStreamCriticalStorage<Contents>: @unchecked Sendable {
       UnsafeRawPointer(Builtin.projectTailElems(self, UnsafeRawPointer.self))
     _unlock(ptr)
   }
-  
+
   var value: Contents {
     get {
       lock()
       let contents = _value
       unlock()
       return contents
     }
-    
+
     set {
       lock()
       withExtendedLifetime(_value) {
@@ -575,7 +575,7 @@ final class _AsyncStreamCriticalStorage<Contents>: @unchecked Sendable {
       }
     }
   }
-  
+
   static func create(_ initial: Contents) -> _AsyncStreamCriticalStorage {
     let minimumCapacity = _lockWordCount()
     let storage = Builtin.allocWithTailElems_1(