Merge pull request #60868 from AnthonyLatsis/migrate-test-suite-to-gh-issues-15

Gardening: Migrate test suite to GH issues p. 15

Author: AnthonyLatsis

test/IDE/coloring_class_restriction.swift

@@ -2,7 +2,7 @@
 // RUN: %target-swift-ide-test -syntax-coloring -typecheck -source-filename %s | %FileCheck %s
 
 // NOTE: Testing 'class' at the end of the file. Don't add anything after that.
-// https://bugs.swift.org/browse/SR-8378
+// https://github.com/apple/swift/issues/50905
 
 // CHECK: <kw>protocol</kw> P : <type>class</type>
 protocol P : class

test/IDE/complete_call_arg.swift

@@ -930,11 +930,13 @@ func testCompleteLabelAfterVararg() {
     // COMPLETE_MEMBER_IN_VARARG: End completions
   }
 
-  struct Sr14515 {
+  // https://github.com/apple/swift/issues/56867
+
+  struct S_56867 {
     func test(_: Foo..., yArg: Baz) {}
   }
 
-  private func testSr14515(value: Sr14515, foo: Foo, baz: Baz) {
+  private func test_56867(value: S_56867, foo: Foo, baz: Baz) {
     value.test(foo, #^COMPLETE_VARARG_FOLLOWED_BY_NORMAL_ARG^#)
     // COMPLETE_VARARG_FOLLOWED_BY_NORMAL_ARG: Begin completions
     // COMPLETE_VARARG_FOLLOWED_BY_NORMAL_ARG-DAG: Decl[LocalVar]/Local/TypeRelation[Convertible]: foo[#Foo#];
@@ -995,15 +997,17 @@ struct Rdar77867723 {
   }
 }
 
-struct SR14737<T> {
+// https://github.com/apple/swift/issues/57087
+
+struct S_57087<T> {
   init(arg1: T, arg2: Bool) {}
 }
-extension SR14737 where T == Int {
+extension S_57087 where T == Int {
   init(arg1: T, onlyInt: Bool) {}
 }
-func test_SR14737() {
+do {
   invalidCallee {
-    SR14737(arg1: true, #^GENERIC_INIT_IN_INVALID^#)
+    S_57087(arg1: true, #^GENERIC_INIT_IN_INVALID^#)
 // GENERIC_INIT_IN_INVALID: Begin completions, 1 item
 // GENERIC_INIT_IN_INVALID-DAG: Pattern/Local/Flair[ArgLabels]:     {#arg2: Bool#}[#Bool#];
 // GENERIC_INIT_IN_INVALID: End completions

test/IDE/complete_constrained.swift

@@ -88,7 +88,8 @@ func foo(s: MyStruct<Int>) {
 // META_MYSTRUCT_INT_DOT: End completions
 }
 
-//https://bugs.swift.org/browse/SR-9938
+// https://github.com/apple/swift/issues/52344
+
 enum Fruit     { case apple }
 enum Vegetable { case broccoli }
 enum Meat      { case chicken }

test/IDE/complete_generic_optional.swift

@@ -8,7 +8,9 @@ struct Foo<T> {
   }
 }
 
-// SR-642 Code completion does not instantiate generic arguments of a type wrapped in an optional
+// https://github.com/apple/swift/issues/43259
+// Code completion does not instantiate generic arguments of a type wrapped
+// in an optional
 let x: Foo<Bar>? = Foo<Bar>()
 x.#^FOO_OPTIONAL_1^#
 // FOO_OPTIONAL_1: Begin completions, 7 items

test/IDE/complete_generic_param.swift

@@ -39,27 +39,30 @@ class C3 {
 // INHERIT-NOT: ValueString2
 // INHERIT-NOT: TopLevelFunc
 
+// https://github.com/apple/swift/issues/56788
 
-class Sr14432<T, U> {}
+class C4<T, U> {}
 
-_ = Sr14432<#^GENERIC_TYPE_PARAM^# >()
-_ = Sr14432<SomeType, #^SECOND_GENERIC_TYPE_PARAM^# >()
+_ = C4<#^GENERIC_TYPE_PARAM^# >()
+_ = C4<SomeType, #^SECOND_GENERIC_TYPE_PARAM^# >()
 // GENERIC_TYPE_PARAM: Begin completions
 // GENERIC_TYPE_PARAM-DAG: Decl[Class]/CurrModule:             C1[#C1#];
 // GENERIC_TYPE_PARAM: End completions
 
-struct Sr14627 {
+// https://github.com/apple/swift/issues/56979
+
+struct S2 {
   struct Nested<Elements> {
-    init() { fatalError() }
+    init() {}
   }
 }
 
-var sr14627_globalVar = Sr14627.Nested< #^GENERIC_PARAM_ON_NESTED_TYPE_GLOBAL_VAR^#>()
+var s2_globalVar = S2.Nested< #^GENERIC_PARAM_ON_NESTED_TYPE_GLOBAL_VAR^#>()
 
 func someFunction() {
-  var sr14627_localVar = Sr14627.Nested< #^GENERIC_PARAM_ON_NESTED_TYPE_LOCAL_VAR^#>()
+  var s2_localVar = S2.Nested< #^GENERIC_PARAM_ON_NESTED_TYPE_LOCAL_VAR^#>()
 }
 
 // GENERIC_PARAM_ON_NESTED_TYPE: Begin completions
-// GENERIC_PARAM_ON_NESTED_TYPE-DAG: Decl[Struct]/CurrModule:            Sr14627[#Sr14627#];
+// GENERIC_PARAM_ON_NESTED_TYPE-DAG: Decl[Struct]/CurrModule:            S2[#S2#];
 // GENERIC_PARAM_ON_NESTED_TYPE: End completions

test/IDE/complete_import_overloads.swift

@@ -9,9 +9,10 @@
 
 import library
 
+// https://github.com/apple/swift/issues/49889
 // Ensure we maintain compatibility with Swift 4's overload signature rules.
 // Variables defined in extensions of generic types had different overload
-// signatures to other variables, so allow overloading in such cases (SR-7341).
+// signatures to other variables, so allow overloading in such cases.
 extension HasFooGeneric {
   var foo: String { return "" } // foo isn't defined in a generic extension in the other module, so allow overloading in Swift 4 mode.
   var bar: String { return "" } // bar is defined in a generic extension in the other module, so `bar: String` always shadows it.

test/IDE/complete_member_decls_from_parent_decl_context.swift

@@ -31,8 +31,8 @@
 
 // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=NESTED_NOMINAL_DECL_E_1 | %FileCheck %s -check-prefix=NESTED_NOMINAL_DECL_E_1
 
-// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=SR627_SUBCLASS | %FileCheck %s -check-prefix=SR627_SUBCLASS
-// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=SR627_SUB_SUBCLASS | %FileCheck %s -check-prefix=SR627_SUB_SUBCLASS
+// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=ISSUE_43244_SUBCLASS | %FileCheck %s -check-prefix=ISSUE_43244_SUBCLASS
+// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=ISSUE_43244_SUB_SUBCLASS | %FileCheck %s -check-prefix=ISSUE_43244_SUB_SUBCLASS
 
 //===---
 //===--- Test that we can code complete in methods, and correctly distinguish
@@ -598,22 +598,23 @@ func testOuterE() {
 // NESTED_NOMINAL_DECL_E_1-NOT: dFunc6()
 // NESTED_NOMINAL_DECL_E_1: End completions
 
-class SR627_BaseClass<T> {
-  func myFunction(_ x: T) -> T? {
-    return nil
+// https://github.com/apple/swift/issues/43244
+do {
+  class BaseClass<T> {
+    func myFunction(_ x: T) -> T? {}
   }
-}
 
-class SR627_Subclass: SR627_BaseClass<String> {
-  #^SR627_SUBCLASS^#
-// SR627_SUBCLASS: Begin completions
-// SR627_SUBCLASS-DAG: Decl[InstanceMethod]/Super:         override func myFunction(_ x: String) -> String? {|}; name=myFunction(:)
-// SR627_SUBCLASS: End completions
-}
+  class Subclass: BaseClass<String> {
+    #^ISSUE_43244_SUBCLASS^#
+  // ISSUE_43244_SUBCLASS: Begin completions
+  // ISSUE_43244_SUBCLASS-DAG: Decl[InstanceMethod]/Super:         override func myFunction(_ x: String) -> String? {|}; name=myFunction(:)
+  // ISSUE_43244_SUBCLASS: End completions
+  }
 
-class SR627_SubSubclass: SR627_Subclass {
-  #^SR627_SUB_SUBCLASS^#
-  // SR627_SUB_SUBCLASS: Begin completions
-  // SR627_SUB_SUBCLASS-DAG: Decl[InstanceMethod]/Super:         override func myFunction(_ x: String) -> String? {|}; name=myFunction(:)
-  // SR627_SUB_SUBCLASS: End completions
+  class SubSubclass: Subclass {
+    #^ISSUE_43244_SUB_SUBCLASS^#
+    // ISSUE_43244_SUB_SUBCLASS: Begin completions
+    // ISSUE_43244_SUB_SUBCLASS-DAG: Decl[InstanceMethod]/Super:         override func myFunction(_ x: String) -> String? {|}; name=myFunction(:)
+    // ISSUE_43244_SUB_SUBCLASS: End completions
+  }
 }

test/IDE/complete_multiple_files.swift

@@ -50,11 +50,13 @@ func moduleScoped() {
 // MODULE_SCOPED-NOT: ERROR
 // MODULE_SCOPED: End completions
 
+// https://github.com/apple/swift/issues/57800
+
 enum Foo {
     case bar
 }
 
-var sr15495: Void = {
+var _: Void = {
     let foo: Foo = .#^VAR_INITIALIZED_BY_CALLING_CLOSURE^#
 }()
 

test/IDE/complete_multiple_trailingclosure.swift

@@ -205,7 +205,7 @@ func testFallbackPostfix() {
 // doesn't match the already-provided parameters (missing `name` label argument
 // and closure does not return `String`). However, we are not type-checking at
 // the stage at which we complete argument labels, so we can't rule it out for
-// now (SR-14450).
+// now. (https://github.com/apple/swift/issues/56806)
 // INIT_FALLBACK_1: Begin completions, 3 items
 // INIT_FALLBACK_1-DAG: Pattern/Local/Flair[ArgLabels]:     {#arg3: () -> _ {|}#}[#() -> _#]
 // INIT_FALLBACK_1-DAG: Decl[InstanceMethod]/CurrNominal:   .testStructMethod()[#Void#];

test/IDE/complete_override.swift

@@ -387,16 +387,18 @@ class OmitKW10: ProtocolA {
 // WITH_PA
 }
 
-protocol SR2560Proto {
+// https://github.com/apple/swift/issues/45165
+
+protocol P_45165 {
   func foo<S : Sequence>(x: S) where S.Iterator.Element == Int
 }
-class SR2560Class: SR2560Proto {
-  #^SR2560_WHERE_CLAUSE?keywords=false^#
+class C_45165: P_45165 {
+  #^ISSUE_45165_WHERE_CLAUSE?keywords=false^#
 }
 
-// SR2560_WHERE_CLAUSE: Begin completions
-// SR2560_WHERE_CLAUSE: Decl[InstanceMethod]/Super: func foo<S>(x: S) where S : Sequence, S.Element == Int {|};
-// SR2560_WHERE_CLAUSE: End completions
+// ISSUE_45165_WHERE_CLAUSE: Begin completions
+// ISSUE_45165_WHERE_CLAUSE: Decl[InstanceMethod]/Super: func foo<S>(x: S) where S : Sequence, S.Element == Int {|};
+// ISSUE_45165_WHERE_CLAUSE: End completions
 
 protocol HasThrowingProtocol {
   func foo() throws
@@ -758,10 +760,11 @@ class SynthesizedConformance5: SynthesizedConformance2 {
 // FIXME: 'required init(from decoder: Decoder)' is suggested twice
 }
 
-protocol ProtocolSr14687 {
+// https://github.com/apple/swift/issues/57037
+protocol P_57037 {
   var value: Int { get }
 }
-struct StructSr14687: ProtocolSr14687 {
+struct S_57037: P_57037 {
   let foo = val, #^MULTI_VAR_DECL_OVERRIDE^#
 // MULTI_VAR_DECL_OVERRIDE:     Begin completions, 1 items
 // MULTI_VAR_DECL_OVERRIDE-DAG: Decl[InstanceVar]/Super:            value: Int;