Skip to content

Commit bd39c35

Browse files
committed
[test] Un-xfail tests that are passing now that NoncopyableGenerics is a suppressible feature
1 parent e839230 commit bd39c35

File tree

7 files changed

+4
-17
lines changed

7 files changed

+4
-17
lines changed

test/APIJSON/extension.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) %s -typecheck -parse-as-library -emit-module-interface-path %t/MyModule.swiftinterface -enable-library-evolution -module-name MyModule -swift-version 5 -emit-api-descriptor-path %t/api.json
77
// RUN: %validate-json %t/api.json | %FileCheck %s --check-prefixes=CHECK,CHECK-EMIT
88

9-
// FIXME(NCG): This test requires NoncopyableGenerics to be a "suppressible" compiler feature.
10-
// XFAIL: !noncopyable_generics
11-
129
import Foundation
1310

1411
// This should create an ObjC Category and a method with custom name.

test/Concurrency/dynamic_checks_for_func_refs_in_preconcurrency_apis.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@
2929
// REQUIRES: asserts
3030
// REQUIRES: concurrency
3131

32-
// FIXME(NCG): This test requires NoncopyableGenerics to be a "suppressible" compiler feature.
33-
// XFAIL: !noncopyable_generics
34-
3532
//--- API.swift
3633
public func compute<T>(_: ((T) -> Void)?) {}
3734

test/ModuleInterface/features.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,13 @@ public class OldSchool2: MP {
9090
// CHECK: public struct UsesRP {
9191
public struct UsesRP {
9292
// CHECK: #if compiler(>=5.3) && $RethrowsProtocol
93+
// CHECK-NEXT: #if $NoncopyableGenerics
9394
// CHECK-NEXT: public var value: (any FeatureTest.RP)? {
9495
// CHECK-NOT: #if compiler(>=5.3) && $RethrowsProtocol
9596
// CHECK: get
97+
// CHECK: #else
98+
// CHECK-NEXT: public var value: (any FeatureTest.RP)? {
99+
// CHECK-NEXT: get
96100
public var value: RP? {
97101
nil
98102
}

test/ModuleInterface/result_builders.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
// RUN: %target-swift-frontend -compile-module-from-interface %t/ResultBuilders.swiftinterface -o %t/ResultBuilders.swiftmodule
66
// RUN: %FileCheck %s < %t/ResultBuilders.swiftinterface
77

8-
// FIXME(NCG): This test requires NoncopyableGenerics to be a "suppressible" compiler feature.
9-
// XFAIL: !noncopyable_generics
10-
118
// CHECK: @_functionBuilder public struct TupleBuilder
129
@resultBuilder
1310
public struct TupleBuilder {

test/ModuleInterface/swift_build_sdk_interfaces/track-system-dependencies.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
// RUN: %target-typecheck-verify-swift -sdk %t/sdk -I %t/sdk/usr/lib/swift/ -module-cache-path %t/MCP
3131
// RUN: not %{python} %S/../ModuleCache/Inputs/check-is-forwarding-module.py %t/MCP/Swifty-*.swiftmodule
3232

33-
// FIXME(NCG): This test requires NoncopyableGenerics to be a "suppressible" compiler feature.
34-
// XFAIL: !noncopyable_generics
35-
3633
import Swifty
3734

3835
usesCStruct(nil)

test/api-digester/compare-dump-abi-parsable-interface.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,5 @@
1313
// RUN: %clang -E -P -x c %t.result -o - | sed '/^\s*$/d' > %t.result.tmp
1414
// RUN: diff -u %t.expected %t.result.tmp
1515

16-
// FIXME(NCG): Damned if you do, damned if you don't.
1716
// XFAIL: noncopyable_generics
18-
// XFAIL: !noncopyable_generics
1917

test/api-digester/compare-dump-binary-vs-interface.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,3 @@
2929
// RUN: %clang -E -P -x c %S/Outputs/Cake-binary-vs-interface.txt -o - | sed '/^\s*$/d' > %t.expected
3030
// RUN: %clang -E -P -x c %t.result -o - | sed '/^\s*$/d' > %t.result.tmp
3131
// RUN: diff -u %t.expected %t.result.tmp
32-
33-
// FIXME(NCG): This test requires NoncopyableGenerics to be a "suppressible" compiler feature.
34-
// XFAIL: !noncopyable_generics

0 commit comments

Comments
 (0)