PassManager: add a invalidation kind for non-body function data

E.g. used if function effects are changed. This tells the passmanager that something changed, but no SIL-specific analysis have to be invalidated.

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/PassManager/PassContext.swift

@@ -117,8 +117,8 @@ struct PassContext {
   }
 
   func modifyEffects(in function: Function, _ body: (inout FunctionEffects) -> ()) {
+    notifyFunctionDataChanged()
     function._modifyEffects(body)
-    // TODO: do we need to notify any changes?
   }
 
   //===--------------------------------------------------------------------===//
@@ -136,6 +136,10 @@ struct PassContext {
   fileprivate func notifyBranchesChanged() {
     PassContext_notifyChanges(_bridged, branchesChanged)
   }
+
+  fileprivate func notifyFunctionDataChanged() {
+    PassContext_notifyChanges(_bridged, functionDataChanged)
+  }
 }
 
 //===----------------------------------------------------------------------===//

include/swift/SIL/SILBridging.h

@@ -29,7 +29,8 @@ enum {
 enum ChangeNotificationKind {
   instructionsChanged,
   callsChanged,
-  branchesChanged
+  branchesChanged,
+  functionDataChanged
 };
 
 typedef struct {

include/swift/SILOptimizer/Analysis/Analysis.h

@@ -64,14 +64,20 @@ class SILAnalysis {
     /// has been modified.
     Branches = 0x4,
 
+    /// Any function data other than its body.
+    ///
+    /// It does not trigger any analysis invalidation, but tells the pass
+    /// manager that some changes were made.
+    FunctionData = 0x8,
+
     /// Convenience states:
     FunctionBody = Calls | Branches | Instructions,
 
     CallsAndInstructions = Calls | Instructions,
 
     BranchesAndInstructions = Branches | Instructions,
 
-    Everything = Calls | Branches | Instructions,
+    Everything = Calls | Branches | Instructions | FunctionData,
   };
 
 private:

lib/SILOptimizer/PassManager/PassManager.cpp

@@ -1380,6 +1380,9 @@ void PassContext_notifyChanges(BridgedPassContext passContext,
   case branchesChanged:
     inv->notifyChanges(SILAnalysis::InvalidationKind::BranchesAndInstructions);
     break;
+  case functionDataChanged:
+    inv->notifyChanges(SILAnalysis::InvalidationKind::FunctionData);
+    break;
   }
 }