Skip to content

Commit c1c75a4

Browse files
committed
build: drop LINK_FLAGS from add_swift_host_library
This is not currently being used. Unfortunately, setting linker options is difficult until CMake 3.13 which introduced target_link_options. Prior to that, you needed to do: set_property(TARGET <TARGET> APPEND_STRING LINK_FLAGS <NEW FLAGS>) If needed, we could write a helper to provide the target_link_options interface on earlier CMake versions.
1 parent 31a5ae7 commit c1c75a4

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

cmake/modules/AddSwift.cmake

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1357,7 +1357,6 @@ endfunction()
13571357
# [SWIFT_MODULE_DEPENDS dep1 ...]
13581358
# [LLVM_COMPONENT_DEPENDS comp1 ...]
13591359
# [FILE_DEPENDS target1 ...]
1360-
# [LINK_FLAGS flag1...]
13611360
# [INSTALL]
13621361
# INSTALL_IN_COMPONENT comp
13631362
# source1 [source2 source3 ...])
@@ -1380,9 +1379,6 @@ endfunction()
13801379
# FILE_DEPENDS
13811380
# Additional files this library depends on.
13821381
#
1383-
# LINK_FLAGS
1384-
# Extra linker flags.
1385-
#
13861382
# INSTALL_IN_COMPONENT comp
13871383
# The Swift installation component that this library belongs to.
13881384
#
@@ -1399,7 +1395,6 @@ function(add_swift_host_library name)
13991395
DEPENDS
14001396
FILE_DEPENDS
14011397
INTERFACE_LINK_LIBRARIES
1402-
LINK_FLAGS
14031398
LINK_LIBRARIES
14041399
LLVM_COMPONENT_DEPENDS)
14051400

@@ -1438,7 +1433,6 @@ function(add_swift_host_library name)
14381433
DEPENDS ${ASHL_DEPENDS}
14391434
LLVM_COMPONENT_DEPENDS ${ASHL_LLVM_COMPONENT_DEPENDS}
14401435
FILE_DEPENDS ${ASHL_FILE_DEPENDS}
1441-
LINK_FLAGS ${ASHL_LINK_FLAGS}
14421436
INSTALL_IN_COMPONENT "dev"
14431437
)
14441438

0 commit comments

Comments
 (0)