[NFC] Give withoutArgumentLabels() a context arg

It will soon need to allocate sometimes.

# Conflicts:
#	lib/IDE/ExprContextAnalysis.cpp

Author: beccadax

include/swift/AST/Identifier.h

@@ -747,7 +747,7 @@ class DeclNameRef {
     return lhs.compare(rhs) >= 0;
   }
 
-  DeclNameRef withoutArgumentLabels() const;
+  DeclNameRef withoutArgumentLabels(ASTContext &C) const;
   DeclNameRef withArgumentLabels(ASTContext &C,
                                  ArrayRef<Identifier> argumentNames) const;
 
@@ -781,7 +781,7 @@ inline DeclNameRef DeclNameRef::getFromOpaqueValue(void *p) {
   return DeclNameRef(DeclName::getFromOpaqueValue(p));
 }
 
-inline DeclNameRef DeclNameRef::withoutArgumentLabels() const {
+inline DeclNameRef DeclNameRef::withoutArgumentLabels(ASTContext &C) const {
   return DeclNameRef(getBaseName());
 }
 
@@ -790,7 +790,6 @@ inline DeclNameRef DeclNameRef::withArgumentLabels(
   return DeclNameRef(DeclName(C, getBaseName(), argumentNames));
 }
 
-
 inline DeclNameRef DeclNameRef::createSubscript() {
   return DeclNameRef(DeclBaseName::createSubscript());
 }

lib/IDE/ExprContextAnalysis.cpp

@@ -448,7 +448,7 @@ static void collectPossibleCalleesByQualifiedLookup(
 
   SmallVector<ValueDecl *, 2> decls;
   if (!DC.lookupQualified(baseInstanceTy,
-                          name.withoutArgumentLabels(),
+                          name.withoutArgumentLabels(DC.getASTContext()),
                           NL_QualifiedDefault | NL_ProtocolMembers,
                           decls))
     return;

lib/Sema/CSDiagnostics.cpp

@@ -3662,7 +3662,8 @@ bool MissingMemberFailure::diagnoseAsError() {
       auto &cs = getConstraintSystem();
 
       auto result = cs.performMemberLookup(
-          ConstraintKind::ValueMember, getName().withoutArgumentLabels(),
+          ConstraintKind::ValueMember,
+          getName().withoutArgumentLabels(getASTContext()),
           metatypeTy, FunctionRefKind::DoubleApply, getLocator(),
           /*includeInaccessibleMembers=*/true);
 

lib/Sema/TypeCheckAttr.cpp

@@ -5738,9 +5738,10 @@ ValueDecl *RenamedDeclRequest::evaluate(Evaluator &evaluator,
   if (attr->Rename.empty())
     return nullptr;
 
+  auto &ctx = attached->getASTContext();
   auto attachedContext = attached->getDeclContext();
   auto parsedName = parseDeclName(attr->Rename);
-  auto nameRef = parsedName.formDeclNameRef(attached->getASTContext());
+  auto nameRef = parsedName.formDeclNameRef(ctx);
 
   // Handle types separately
   if (isa<NominalTypeDecl>(attached)) {
@@ -5749,7 +5750,7 @@ ValueDecl *RenamedDeclRequest::evaluate(Evaluator &evaluator,
 
     SmallVector<ValueDecl *, 1> lookupResults;
     attachedContext->lookupQualified(attachedContext->getParentModule(),
-                                     nameRef.withoutArgumentLabels(),
+                                     nameRef.withoutArgumentLabels(ctx),
                                      NL_OnlyTypes, lookupResults);
     if (lookupResults.size() == 1)
       return lookupResults[0];

lib/Sema/TypeCheckPattern.cpp

@@ -119,7 +119,7 @@ static EnumElementDecl *
 lookupUnqualifiedEnumMemberElement(DeclContext *DC, DeclNameRef name,
                                    SourceLoc UseLoc) {
   // FIXME: We should probably pay attention to argument labels someday.
-  name = name.withoutArgumentLabels();
+  name = name.withoutArgumentLabels(DC->getASTContext());
 
   auto lookup =
       TypeChecker::lookupUnqualified(DC, name, UseLoc,
@@ -136,7 +136,7 @@ lookupEnumMemberElement(DeclContext *DC, Type ty,
     return nullptr;
 
   // FIXME: We should probably pay attention to argument labels someday.
-  name = name.withoutArgumentLabels();
+  name = name.withoutArgumentLabels(DC->getASTContext());
 
   // Look up the case inside the enum.
   // FIXME: We should be able to tell if this is a private lookup.

lib/Sema/TypeCheckProtocol.cpp

@@ -1228,7 +1228,7 @@ WitnessChecker::lookupValueWitnesses(ValueDecl *req, bool *ignoringNames) {
   lookupValueWitnessesViaImplementsAttr(req, witnesses);
 
   auto reqName = req->createNameRef();
-  auto reqBaseName = reqName.withoutArgumentLabels();
+  auto reqBaseName = reqName.withoutArgumentLabels(DC->getASTContext());
 
   if (req->isOperator()) {
     // Operator lookup is always global.