Skip to content

Commit c5256ff

Browse files
committed
Fix continue statements incorrectly changed to returns
When this function was extracted from a for loop, continue was mapped to return, but these nested continues should remain.
1 parent 5422c8d commit c5256ff

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lib/Frontend/DiagnosticVerifier.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -893,13 +893,13 @@ unsigned DiagnosticVerifier::parseExpectedDiagInfo(
893893
addError(CheckStr.data(),
894894
"each verified diagnostic may only have one "
895895
"{{documentation-file=<#notes#>}} declaration");
896-
return 0;
896+
continue;
897897
}
898898

899899
// Trim 'documentation-file='.
900900
StringRef name = CheckStr.substr(categoryDocFileSpecifier.size());
901901
Expected.DocumentationFile = {OpenLoc, CloseLoc, name};
902-
return 0;
902+
continue;
903903
}
904904

905905
// This wasn't a documentation file specifier, so it must be a fix-it.
@@ -914,7 +914,7 @@ unsigned DiagnosticVerifier::parseExpectedDiagInfo(
914914
}
915915

916916
Expected.noneMarkerStartLoc = CheckStr.data() - 2;
917-
return 0;
917+
continue;
918918
}
919919

920920
if (Expected.noneMarkerStartLoc) {
@@ -928,7 +928,7 @@ unsigned DiagnosticVerifier::parseExpectedDiagInfo(
928928
addError(CheckStr.data(), Twine("expected fix-it verification within "
929929
"braces; example: '1-2=text' or '") +
930930
fixitExpectationNoneString + Twine("'"));
931-
return 0;
931+
continue;
932932
}
933933

934934
// Parse the pieces of the fix-it.
@@ -940,15 +940,15 @@ unsigned DiagnosticVerifier::parseExpectedDiagInfo(
940940
parseExpectedFixItRange(CheckStr, Expected.LineNo)) {
941941
FixIt.Range = range.value();
942942
} else {
943-
return 0;
943+
continue;
944944
}
945945

946946
if (!CheckStr.empty() && CheckStr.front() == '=') {
947947
CheckStr = CheckStr.drop_front();
948948
} else {
949949
addError(CheckStr.data(),
950950
"expected '=' after range in fix-it verification");
951-
return 0;
951+
continue;
952952
}
953953

954954
// Translate literal "\\n" into '\n', inefficiently.

0 commit comments

Comments
 (0)