Skip to content

Commit c57bc03

Browse files
committed
[move-function] Update filecheck pattern for upstream LLVM change that ensures we emit llvm.dbg.addr on inouts correctly.
Before, we were silently hoisting the llvm.dbg.addr associated with this value. Now LLVM understands not to do that, so we appropriately get the two variable locations.
1 parent ea09951 commit c57bc03

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

test/DebugInfo/move_function_dbginfo.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,7 @@ public func copyableVarTest() {
198198
// We check that we get two separate locations for the different lifetimes of
199199
// the values.
200200
// DWARF-NEXT: [0x{{[a-z0-9]+}}, 0x{{[a-z0-9]+}}):
201-
// TODO: This is incorrect.
202-
// XWARF-NEXT: [0x{{[a-z0-9]+}}, 0x{{[a-z0-9]+}}):
201+
// DWARF-NEXT: [0x{{[a-z0-9]+}}, 0x{{[a-z0-9]+}}):
203202
// DWARF-NEXT: DW_AT_name ("k")
204203
// DWARF-NEXT: DW_AT_decl_file (
205204
// DWARF-NEXT: DW_AT_decl_line (
@@ -391,8 +390,7 @@ public func addressOnlyVarTest<T : P>(_ x: T) {
391390
// DWARF: DW_TAG_formal_parameter
392391
// DWARF-NEXT: DW_AT_location (0x{{[a-z0-9]+}}:
393392
// DWARF-NEXT: [0x{{[a-z0-9]+}}, 0x{{[a-z0-9]+}}):
394-
// TODO: We are missing a debug_value in codegen.
395-
// XWARF-NEXT: [0x{{[a-z0-9]+}}, 0x{{[a-z0-9]+}}):
393+
// DWARF-NEXT: [0x{{[a-z0-9]+}}, 0x{{[a-z0-9]+}}):
396394
// DWARF-NEXT: DW_AT_name ("k")
397395
// DWARF-NEXT: DW_AT_decl_file (
398396
// DWARF-NEXT: DW_AT_decl_line (

0 commit comments

Comments
 (0)