Merge pull request #37521 from LucianoPAlmeida/SR-14644-keypath

[Sema][Diagnostics][SR-14644] Improving diagnostics for key path with invalid components

Author: LucianoPAlmeida

include/swift/AST/Expr.h

@@ -5842,7 +5842,10 @@ class KeyPathExpr : public Expr {
   /// Indicates if the key path expression is composed by a single invalid
   /// component. e.g. missing component `\Root`
   bool hasSingleInvalidComponent() const {
-    return Components.size() == 1 && !Components.front().isValid();
+    if (ParsedRoot && ParsedRoot->getKind() == ExprKind::Type) {
+      return Components.size() == 1 && !Components.front().isValid();
+    }
+    return false;
   }
 
   /// Retrieve the string literal expression, which will be \c NULL prior to

lib/Sema/CSBindings.cpp

@@ -1851,6 +1851,15 @@ TypeVariableBinding::fixForHole(ConstraintSystem &cs) const {
     if (cs.hasFixFor(kpLocator, FixKind::AllowKeyPathWithoutComponents))
       return None;
 
+    // If key path has any invalid component, let's just skip fix because the
+    // invalid component would be already diagnosed.
+    auto keyPath = castToExpr<KeyPathExpr>(srcLocator->getAnchor());
+    if (llvm::any_of(keyPath->getComponents(),
+                     [](KeyPathExpr::Component component) {
+                       return !component.isValid();
+                     }))
+      return None;
+
     ConstraintFix *fix = SpecifyKeyPathRootType::create(cs, dstLocator);
     return std::make_pair(fix, defaultImpact);
   }

test/expr/unary/keypath/keypath.swift

@@ -1054,6 +1054,16 @@ func testSyntaxErrors() {
   _ = \A.a!;
 }
 
+// SR-14644
+func sr14644() {
+  _ = \Int.byteSwapped.signum() // expected-error {{invalid component of Swift key path}}
+  _ = \Int.byteSwapped.init() // expected-error {{invalid component of Swift key path}}
+  _ = \Int // expected-error {{key path must have at least one component}}
+  _ = \Int? // expected-error {{key path must have at least one component}}
+  _ = \Int. // expected-error {{invalid component of Swift key path}}
+  // expected-error@-1 {{expected member name following '.'}}
+}
+
 // SR-13364 - keypath missing optional crashes compiler: "Inactive constraints left over?"
 func sr13364() {
   let _: KeyPath<String?, Int?> = \.utf8.count // expected-error {{no exact matches in reference to property 'count'}}