Merge pull request #77326 from sophiapoirier/preconcurrency_import_warning_for_suppressed_sendable_diagnostic_comment

sophiapoirier · web-flow · commit c9cb122087c2 · 2024-11-01T11:22:43.000-07:00
[Concurrency] add comment about bug causing Sendable conformance test…
diff --git a/test/Concurrency/sendable_conformance_checking.swift b/test/Concurrency/sendable_conformance_checking.swift
@@ -211,6 +211,7 @@ public struct TestSendableWitnesses2 : NoSendableReqs {
   @preconcurrency func f(handler: @escaping @MainActor @Sendable (Int) -> Void)
 }
 
+// TODO: The following error should actually be a warning.
 // expected-complete-and-tns-error @+2 {{type 'TestEscapingOnly' does not conform to protocol 'EscapingSendableProtocol'}}
 // expected-complete-and-tns-note @+1 {{add stubs for conformance}}
 class TestEscapingOnly: EscapingSendableProtocol {

Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,7 @@ public struct TestSendableWitnesses2 : NoSendableReqs {`
`211`	`211`	`@preconcurrency func f(handler: @escaping @MainActor @Sendable (Int) -> Void)`
`212`	`212`	`}`
`213`	`213`
	`214`	`+// TODO: The following error should actually be a warning.`
`214`	`215`	`// expected-complete-and-tns-error @+2 {{type 'TestEscapingOnly' does not conform to protocol 'EscapingSendableProtocol'}}`
`215`	`216`	`// expected-complete-and-tns-note @+1 {{add stubs for conformance}}`
`216`	`217`	`class TestEscapingOnly: EscapingSendableProtocol {`