Skip to content

Commit d05f45b

Browse files
committed
[CMake] Don't add unnecessary gyb support .py files
'add_gyb_target' can accept 'DEPENDS'. Utilize it.
1 parent becdbaa commit d05f45b

File tree

5 files changed

+16
-27
lines changed

5 files changed

+16
-27
lines changed

cmake/modules/SwiftHandleGybSources.cmake

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -122,27 +122,7 @@ function(handle_gyb_sources dependency_out_var_name sources_var_name)
122122
"${SWIFT_SOURCE_DIR}/utils/SwiftFloatingPointTypes.py"
123123
"${SWIFT_SOURCE_DIR}/utils/UnicodeData/GraphemeBreakProperty.txt"
124124
"${SWIFT_SOURCE_DIR}/utils/UnicodeData/GraphemeBreakTest.txt"
125-
"${SWIFT_SOURCE_DIR}/utils/gyb_stdlib_support.py"
126-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/__init__.py"
127-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Child.py"
128-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Classification.py"
129-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/kinds.py"
130-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Node.py"
131-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/AttributeKinds.py"
132-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/AttributeNodes.py"
133-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/AvailabilityNodes.py"
134-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/CommonNodes.py"
135-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/DeclNodes.py"
136-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/ExprNodes.py"
137-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/GenericNodes.py"
138-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/PatternNodes.py"
139-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/StmtNodes.py"
140-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/TypeNodes.py"
141-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Token.py"
142-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Trivia.py"
143-
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Traits.py"
144-
"${SWIFT_SOURCE_DIR}/utils/gyb_sourcekit_support/__init__.py"
145-
"${SWIFT_SOURCE_DIR}/utils/gyb_sourcekit_support/UIDs.py")
125+
"${SWIFT_SOURCE_DIR}/utils/gyb_stdlib_support.py")
146126

147127
foreach (src ${${sources_var_name}})
148128
# On Windows (using Visual Studio), the generated project files assume that the

include/swift/AST/Attr.def.gyb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
%{
22
# -*- mode: C++ -*-
3-
from gyb_syntax_support import *
43
from gyb_syntax_support.AttributeKinds import *
54
# Ignore the following admonition; it applies to the resulting .def file only
65
}%

include/swift/AST/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ set(generated_include_sources
99
TokenKinds.def.gyb)
1010

1111
add_gyb_target(swift-ast-generated-headers
12-
"${generated_include_sources}")
12+
"${generated_include_sources}"
13+
DEPENDS
14+
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/kinds.py"
15+
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/AttributeKinds.py"
16+
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Classification.py"
17+
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Token.py"
18+
"${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/gyb_syntax_support/Utils.py")
1319
set_property(TARGET swift-ast-generated-headers
1420
PROPERTY FOLDER "Miscellaneous")

include/swift/AST/TokenKinds.def.gyb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
%{
22
# -*- mode: Swift -*-
3-
from gyb_syntax_support import *
3+
from gyb_syntax_support.Token import *
44
# Ignore the following admonition it applies to the resulting .def file only
55
}%
66
//// Automatically Generated From TokenKinds.def.gyb.
@@ -145,9 +145,9 @@
145145

146146
// Keywords that start decls.
147147
% for token in SYNTAX_TOKENS:
148-
% if isinstance(token, Token.Punctuator):
148+
% if isinstance(token, Punctuator):
149149
${token.macro_name()}(${token.unprefixed_kind}, "${token.text}")
150-
% elif isinstance(token, Token.PoundObjectLiteral):
150+
% elif isinstance(token, PoundObjectLiteral):
151151
${token.macro_name()}(${token.unprefixed_kind}, "${token.description}", ${token.protocol})
152152
% else:
153153
${token.macro_name()}(${token.unprefixed_kind})
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
1-
add_gyb_target(generated_sourcekit_uids ProtocolUIDs.def.gyb)
1+
add_gyb_target(generated_sourcekit_uids
2+
ProtocolUIDs.def.gyb
3+
DEPENDS
4+
"${SWIFT_SOURCE_DIR}/utils/gyb_sourcekit_support/__init__.py"
5+
"${SWIFT_SOURCE_DIR}/utils/gyb_sourcekit_support/UIDs.py")

0 commit comments

Comments
 (0)