Skip to content

Commit d1141d6

Browse files
authored
Merge pull request #62647 from adrian-prantl/103416237-1
Remove StorageType from DebugTypeInfo::getErrorResult().
2 parents 2c83ff7 + a9f0b2a commit d1141d6

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

lib/IRGen/DebugTypeInfo.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,13 +161,9 @@ DebugTypeInfo DebugTypeInfo::getObjCClass(ClassDecl *theClass,
161161
}
162162

163163
DebugTypeInfo DebugTypeInfo::getErrorResult(swift::Type Ty,
164-
llvm::Type *StorageType,
165164
IRGenModule &IGM) {
166165
auto &TI = IGM.getTypeInfoForUnlowered(Ty);
167-
// FIXME: Enable this. Currently breaks on i386.
168-
// assert(TI.getStorageType() == StorageType);
169166
DebugTypeInfo DbgTy = getFromTypeInfo(Ty, TI, false);
170-
assert(StorageType && "FragmentStorageType is a nullptr");
171167
return DbgTy;
172168
}
173169

lib/IRGen/DebugTypeInfo.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ class DebugTypeInfo {
8787
llvm::Type *StorageType, Size size,
8888
Alignment align);
8989
/// Error type.
90-
static DebugTypeInfo getErrorResult(swift::Type Ty, llvm::Type *StorageType,
91-
IRGenModule &IGM);
90+
static DebugTypeInfo getErrorResult(swift::Type Ty, IRGenModule &IGM);
9291

9392
TypeBase *getType() const { return Type; }
9493

lib/IRGen/IRGenSIL.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4877,8 +4877,7 @@ void IRGenSILFunction::emitErrorResultVar(CanSILFunctionType FnTy,
48774877
return;
48784878
auto DbgTy = DebugTypeInfo::getErrorResult(
48794879
ErrorInfo.getReturnValueType(IGM.getSILModule(), FnTy,
4880-
IGM.getMaximalTypeExpansionContext()),
4881-
ErrorResultSlot->getType(), IGM);
4880+
IGM.getMaximalTypeExpansionContext()),IGM);
48824881
IGM.DebugInfo->emitVariableDeclaration(Builder, Storage, DbgTy,
48834882
getDebugScope(), {}, *Var,
48844883
IndirectValue, ArtificialValue);

0 commit comments

Comments
 (0)