Merge pull request #3453 from milseman/id_as_any

[id as Any] Import with the proper Any type

Author: milseman

lib/AST/Type.cpp

@@ -90,11 +90,7 @@ bool TypeBase::hasReferenceSemantics() {
 }
 
 bool TypeBase::isAny() {
-  if (auto comp = getAs<ProtocolCompositionType>())
-    if (comp->getProtocols().empty())
-      return true;
-  
-  return false;
+  return isEqual(getASTContext().getAnyDecl()->getDeclaredType());
 }
 
 bool TypeBase::isAnyClassReferenceType() {

lib/ClangImporter/ImportDecl.cpp

@@ -1533,7 +1533,9 @@ namespace {
         // should be removed from MappedTypes.def, and this conditional should
         // become unnecessary.
         if (Name.str() == "id" && Impl.SwiftContext.LangOpts.EnableIdAsAny) {
-          return nullptr;
+          Impl.SpecialTypedefNames[Decl->getCanonicalDecl()] =
+              MappedTypeNameKind::DoNothing;
+          return Impl.SwiftContext.getAnyDecl();
         }
 
         bool IsError;

lib/ClangImporter/ImportType.cpp

@@ -968,13 +968,12 @@ namespace {
 
       // id maps to Any in bridgeable contexts, AnyObject otherwise.
       if (type->isObjCIdType()) {
-        if (Impl.SwiftContext.LangOpts.EnableIdAsAny) {
-          return { proto->getDeclaredType(),
-                 ImportHint(ImportHint::ObjCBridged,
-                         ProtocolCompositionType::get(Impl.SwiftContext, {})) };
-        } else {
-          return { proto->getDeclaredType(), ImportHint::ObjCPointer };
-        }
+        if (Impl.SwiftContext.LangOpts.EnableIdAsAny)
+          return {
+              proto->getDeclaredType(),
+              ImportHint(ImportHint::ObjCBridged,
+                         Impl.SwiftContext.getAnyDecl()->getDeclaredType())};
+        return {proto->getDeclaredType(), ImportHint::ObjCPointer};
       }
 
       // Class maps to AnyObject.Type.

test/ClangModules/objc_id_as_any.swift

@@ -15,6 +15,12 @@ struct ArbitraryThing {}
 idLover.takesId(ArbitraryThing())
 
 var x: AnyObject = NSObject()
-idLover.takesArray(ofId: &x)
+idLover.takesArray(ofId: &x) // expected-error{{cannot pass immutable value as inout argument: implicit conversion from 'AnyObject' to 'Any' requires a temporary}}
+var xAsAny = x as Any
+idLover.takesArray(ofId: &xAsAny)
+
 var y: Any = NSObject()
-idLover.takesArray(ofId: &y) // expected-error{{}}
+idLover.takesArray(ofId: &y)
+
+idLover.takesId(x)
+idLover.takesId(y)