[CodeCompletion] Calling a static function on a type is not unapplied

Author: ahoppen

lib/IDE/PostfixCompletion.cpp

@@ -141,7 +141,7 @@ static bool isUnappliedFunctionRef(const OverloadChoice &Choice) {
       // We consider curried member calls as unapplied. E.g.
       //   MyStruct.someInstanceFunc(theInstance)#^COMPLETE^#
       // is unapplied.
-      return BaseTy->is<MetatypeType>();
+      return BaseTy->is<MetatypeType>() && !Choice.getDeclOrNull()->isStatic();
     } else {
       return false;
     }

test/IDE/complete_call_pattern_heuristics.swift

@@ -38,3 +38,14 @@ func subscriptAccess(info: [String: Int]) {
   info[#^SUBSCRIPT_ACCESS^#]
 // SUBSCRIPT_ACCESS: Pattern/Local/Flair[ArgLabels]:     {#keyPath: KeyPath<[String : Int], Value>#}[#KeyPath<[String : Int], Value>#]; name=keyPath:
 }
+
+struct StaticMethods {
+  static func before() {
+      self.after(num)#^AFTER_STATIC_FUNC^#
+  }
+  static func after(_ num: Int) -> (() -> Int) {}
+// AFTER_STATIC_FUNC: Begin completions, 2 items
+// AFTER_STATIC_FUNC-DAG: Keyword[self]/CurrNominal:          .self[#(() -> Int)#];
+// AFTER_STATIC_FUNC-DAG: Pattern/CurrModule/Flair[ArgLabels]: ()[#Int#];
+// AFTER_STATIC_FUNC: End completions
+}