Fix leak in type metadata emission.

rudkx · rudkx · commit d5cc962b1165 · 2016-06-23T13:42:07.000-07:00
We were releasing the owned pointer rather than just letting it get
deleted when the unique_ptr goes out of scope.

Fixes rdar://problem/26245737.
diff --git a/lib/IRGen/GenDecl.cpp b/lib/IRGen/GenDecl.cpp
@@ -2422,7 +2422,6 @@ llvm::GlobalValue *IRGenModule::defineTypeMetadata(CanType concreteType,
   if (replace) {
     auto replacer = llvm::ConstantExpr::getBitCast(var, replace->getType());
     replace->replaceAllUsesWith(replacer);
-    replace.release();
   }
 
   // Keep type metadata around for all types, although the runtime can currently

Original file line number	Diff line number	Diff line change
`@@ -2422,7 +2422,6 @@ llvm::GlobalValue *IRGenModule::defineTypeMetadata(CanType concreteType,`
`2422`	`2422`	`if (replace) {`
`2423`	`2423`	`auto replacer = llvm::ConstantExpr::getBitCast(var, replace->getType());`
`2424`	`2424`	`replace->replaceAllUsesWith(replacer);`
`2425`		`- replace.release();`
`2426`	`2425`	`}`
`2427`	`2426`
`2428`	`2427`	`// Keep type metadata around for all types, although the runtime can currently`