Merge pull request #61937 from CodaFi/mcmainerberry

[SILGen] Look for the C-Language Copy of UIApplicationMain

Author: CodaFi

lib/SILGen/SILGenFunction.cpp

@@ -631,16 +631,22 @@ void SILGenFunction::emitArtificialTopLevel(Decl *mainDecl) {
       ->loadModule(SourceLoc(),
                    ImportPath::Module(llvm::makeArrayRef(UIKitName)));
     assert(UIKit && "couldn't find UIKit objc module?!");
-    SmallVector<ValueDecl *, 1> results;
+    SmallVector<ValueDecl *, 2> results;
     UIKit->lookupQualified(UIKit,
                            DeclNameRef(ctx.getIdentifier("UIApplicationMain")),
                            NL_QualifiedDefault,
                            results);
-    assert(results.size() == 1
-           && "couldn't find a unique UIApplicationMain in the UIKit ObjC "
-              "module?!");
 
-    ValueDecl *UIApplicationMainDecl = results.front();
+    // As the comment above alludes, using a qualified lookup into UIKit is
+    // *not* sound. In particular, it's possible for the lookup to find the
+    // (deprecated) Swift copy of UIApplicationMain in UIKit and try to call
+    // that instead of the C entrypoint. Let's try to force this to happen.
+    auto FoundUIApplicationMain = llvm::find_if(results, [](const ValueDecl *VD) {
+      return !VD->getClangNode().isNull();
+    });
+    assert(FoundUIApplicationMain != results.end() &&
+           "Could not find a UIApplicationMain to call!");
+    ValueDecl *UIApplicationMainDecl = *FoundUIApplicationMain;
 
     auto mainRef = SILDeclRef(UIApplicationMainDecl).asForeign();
     SILGenFunctionBuilder builder(SGM);