Merge pull request #62082 from nate-chandler/opaque-values/3/20221112

[AddressLowering] Handle guaranteed destructures.

Author: nate-chandler

lib/SILOptimizer/Mandatory/AddressLowering.cpp

@@ -3004,10 +3004,21 @@ void UseRewriter::rewriteDestructure(SILInstruction *destructure) {
       markRewritten(result, extractAddr);
     } else {
       assert(!pass.valueStorageMap.contains(result));
-      SILValue loadElement = builder.createTrivialLoadOr(
-          destructure->getLoc(), extractAddr, LoadOwnershipQualifier::Take);
-
+      auto guaranteed = !result->getType().isTrivial(*pass.function) &&
+                        destructure->getOperand(0)->getOwnershipKind() ==
+                            OwnershipKind::Guaranteed;
+      SILValue loadElement;
+      if (guaranteed) {
+        loadElement =
+            builder.emitLoadBorrowOperation(destructure->getLoc(), extractAddr);
+      } else {
+        loadElement = builder.createTrivialLoadOr(
+            destructure->getLoc(), extractAddr, LoadOwnershipQualifier::Take);
+      }
       result->replaceAllUsesWith(loadElement);
+      if (guaranteed) {
+        emitEndBorrows(loadElement, pass);
+      }
     }
   }
 }

test/SILOptimizer/address_lowering.sil

@@ -1901,6 +1901,36 @@ exit:
   return %retval : $()
 }
 
+// CHECK-LABEL: sil [ossa] @test_destructure_tuple_1_guaranteed : {{.*}} {
+// CHECK:         [[INSTANCE:%[^,]+]] = unchecked_take_enum_data_addr
+// CHECK:         [[KLASS_ADDR:%[^,]+]] = tuple_element_addr [[INSTANCE]] {{.*}}, 0
+// CHECK:         [[KLASS:%[^,]+]] = load_borrow [[KLASS_ADDR]]
+// CHECK:         end_borrow [[KLASS]]
+// CHECK:         [[ANY_ADDR:%[^,]+]] = tuple_element_addr [[INSTANCE]] {{.*}}, 1
+// CHECK:         apply undef<Any>([[ANY_ADDR]])
+// CHECK:         destroy_addr [[INSTANCE]]
+// CHECK-LABEL: } // end sil function 'test_destructure_tuple_1_guaranteed'
+sil [ossa] @test_destructure_tuple_1_guaranteed : $@convention(thin) () -> () {
+bb0:
+  %maybe = apply undef<(Klass?, Any)>() : $@convention(method) <τ_0_0> () -> @out Optional<τ_0_0>
+  switch_enum %maybe : $Optional<(Optional<Klass>, Any)>, case #Optional.some!enumelt: success, case #Optional.none!enumelt: failure
+success(%instance : @owned $(Optional<Klass>, Any)):
+  %borrow = begin_borrow [lexical] %instance : $(Optional<Klass>, Any)
+  (%klass, %any) = destructure_tuple %borrow : $(Optional<Klass>, Any)
+  apply undef<Any>(%any) : $@convention(thin) <τ_0_0> (@in_guaranteed τ_0_0) -> ()
+  end_borrow %borrow : $(Optional<Klass>, Any)
+  destroy_value %instance : $(Optional<Klass>, Any)
+  br exit
+
+failure:
+  br exit
+
+exit:
+  %505 = tuple ()
+  return %505 : $()
+}
+
+
 // CHECK-LABEL: sil hidden [ossa] @test_store_1 : {{.*}} {
 // CHECK:         [[MAYBE_ADDR:%[^,]+]] = alloc_stack $Optional<Self>
 // CHECK:         [[LOAD_ADDR:%[^,]+]] = alloc_stack $Self