Merge pull request #59873 from DougGregor/unsafe-inherit-executor-stays-on-actor-5.7

Calling `@_unsafeInheritExecutor` functions doesn't exit the current actor

Author: DougGregor

lib/Sema/TypeCheckConcurrency.cpp

@@ -5027,7 +5027,9 @@ ActorReferenceResult ActorReferenceResult::forReference(
   if (!declIsolation.isActorIsolated()) {
     // If the declaration is asynchronous and we are in an actor-isolated
     // context (of any kind), then we exit the actor to the nonisolated context.
-    if (isAsyncDecl(declRef) && contextIsolation.isActorIsolated())
+    if (isAsyncDecl(declRef) && contextIsolation.isActorIsolated() &&
+        !declRef.getDecl()->getAttrs()
+            .hasAttribute<UnsafeInheritExecutorAttr>())
       return forExitsActorToNonisolated(contextIsolation);
 
     // Otherwise, we stay in the same concurrency domain, whether on an actor

test/Concurrency/unsafe_inherit_executor.swift

@@ -20,9 +20,7 @@ struct A {
   func testAsync() async {}
 }
 
-
-@_nonSendable
-class NonSendableObject { // expected-note{{class 'NonSendableObject' does not conform to the 'Sendable' protocol}}
+class NonSendableObject {
   var property = 0
 }
 
@@ -32,7 +30,6 @@ func useNonSendable(object: NonSendableObject) async {}
 actor MyActor {
   var object = NonSendableObject()
   func foo() async {
-    // expected-warning@+1{{non-sendable type 'NonSendableObject' exiting actor-isolated context in call to non-isolated global function 'useNonSendable(object:)' cannot cross actor boundary}}
     await useNonSendable(object: self.object)
   }
 }