@@ -125,7 +125,7 @@ Assuming you followed the steps in our [Getting Started guide][], you should now
125
125
be able to push your latest changes to GitHub using ` git push ` .
126
126
127
127
Next, [ create a pull request] [ ] (PR). Usually, if you navigate to
128
- https://github.com/apple /swift right after pushing your change, GitHub will
128
+ https://github.com/swiftlang /swift right after pushing your change, GitHub will
129
129
show a helpful "Compare & Pull Request" button.
130
130
131
131
![ Compare & Pull Request button in GitHub UI] ( /docs/GitHubCreatePRScreenshot.png )
@@ -135,25 +135,20 @@ show a helpful "Compare & Pull Request" button.
135
135
136
136
## Asking for code review
137
137
138
- Reviews are automatically requested from collaborators and code owners per the
138
+ Reviews are automatically requested from code owners per the
139
139
[ CODEOWNERS] ( /.github/CODEOWNERS ) file upon opening a non-draft pull request.
140
140
If this doesn't happen, @mention and ask a suggested person under ** Reviewers**
141
141
to review your changes in a comment. If no suggestions are shown either, please
142
- @mention and ask a
143
- [ Contributor Experience Workgroup] ( https://www.swift.org/contributor-experience-workgroup/#membership )
144
- member to sort out review requests for you.
142
+ ask @swiftlang/contributor-experience to sort out review requests for you.
145
143
146
144
You are welcome to invite other people for review as well — say, someone you
147
145
had an active discussion with on how to implement your change.
148
146
Anyone with a GitHub account can review or comment on changes proposed to
149
147
this repository!
150
148
151
- Contributors without
152
- [ write access] ( https://swift.org/contributing/#commit-access ) are not able to
153
- run the continuous integration (CI) bot, which builds the project and runs
154
- tests. Please ask a code reviewer with write access to invoke the bot for you.
155
-
156
- [ contributor-experience ] : https://forums.swift.org/g/contributor-experience-workgroup
149
+ Contributors without [ write access] [ write-access ] are not able to run the
150
+ continuous integration (CI) bot, which builds the project and runs tests.
151
+ Please ask a code reviewer with write access to invoke the bot for you.
157
152
158
153
## Responding to code review comments
159
154
@@ -194,13 +189,13 @@ something in the near future. Please don't feel sad or apologetic!
194
189
195
190
Awesome! You are welcome to tackle as many [ good first issues] [ good-first-issues ]
196
191
as it takes for you to gain a desired level of confidence in working with the
197
- codebase. Beyond that, there is an endless supply of [ other issues] ( https://github.com/apple /swift/issues )
192
+ codebase. Beyond that, there is an endless supply of [ other issues] ( https://github.com/swiftlang /swift/issues )
198
193
waiting for a hero. Don't hesitate to ask for help if you need directions or
199
194
get stuck!
200
195
201
196
Once you've made multiple substantial contributions, you can
202
- [ ask for commit access] ( https://swift.org/contributing/#commit-access ) ,
203
- which will allow you to pick reviewers, trigger the CI bot and merge changes
204
- upon approval.
197
+ [ ask for commit access] [ write-access ] , which will allow you to pick reviewers,
198
+ trigger the CI bot and merge changes upon approval.
205
199
206
- [ good-first-issues ] : https://github.com/apple/swift/contribute
200
+ [ good-first-issues ] : https://github.com/swiftlang/swift/contribute
201
+ [ write-access ] : https://swift.org/contributing/#commit-access
0 commit comments