Skip to content

Commit e3e72fc

Browse files
committed
Update benchmark test script to correctly verify the --min-samples=2 default command-line arg
1 parent 7052de9 commit e3e72fc

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

benchmark/scripts/test_Benchmark_Driver.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ def setUp(self):
329329
def test_run_benchmark_with_multiple_samples(self):
330330
self.driver.run("b1")
331331
self.subprocess_mock.assert_called_with(
332-
("/benchmarks/Benchmark_O-*", "b1")
332+
("/benchmarks/Benchmark_O-*", "b1", "--min-samples=2")
333333
)
334334
self.driver.run("b2", num_samples=5)
335335
self.subprocess_mock.assert_called_with(
@@ -339,19 +339,19 @@ def test_run_benchmark_with_multiple_samples(self):
339339
def test_run_benchmark_with_specified_number_of_iterations(self):
340340
self.driver.run("b", num_iters=1)
341341
self.subprocess_mock.assert_called_with(
342-
("/benchmarks/Benchmark_O-*", "b", "--num-iters=1")
342+
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--num-iters=1")
343343
)
344344

345345
def test_run_benchmark_for_specified_time(self):
346346
self.driver.run("b", sample_time=0.5)
347347
self.subprocess_mock.assert_called_with(
348-
("/benchmarks/Benchmark_O-*", "b", "--sample-time=0.5")
348+
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--sample-time=0.5")
349349
)
350350

351351
def test_run_benchmark_in_verbose_mode(self):
352352
self.driver.run("b", verbose=True)
353353
self.subprocess_mock.assert_called_with(
354-
("/benchmarks/Benchmark_O-*", "b", "--verbose")
354+
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--verbose")
355355
)
356356

357357
def test_run_batch(self):
@@ -363,7 +363,7 @@ def test_run_batch(self):
363363
self.driver.tests = ["b1", "bx"]
364364
self.driver.run()
365365
self.subprocess_mock.assert_called_with(
366-
("/benchmarks/Benchmark_O-*", "1", "bx")
366+
("/benchmarks/Benchmark_O-*", "1", "bx", "--min-samples=2")
367367
)
368368

369369
def test_parse_results_from_running_benchmarks(self):
@@ -382,7 +382,7 @@ def test_parse_results_from_running_benchmarks(self):
382382
def test_measure_memory(self):
383383
self.driver.run("b", measure_memory=True)
384384
self.subprocess_mock.assert_called_with(
385-
("/benchmarks/Benchmark_O-*", "b", "--memory")
385+
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--memory")
386386
)
387387

388388
def test_run_benchmark_independent_samples(self):
@@ -394,6 +394,7 @@ def test_run_benchmark_independent_samples(self):
394394
(
395395
"/benchmarks/Benchmark_O-*",
396396
"b1",
397+
"--min-samples=2",
397398
"--num-iters=1",
398399
"--memory",
399400
)

0 commit comments

Comments
 (0)