Skip to content

Commit e6b7808

Browse files
committed
[build-presets] Remove test-sourcekit-lsp
I added the test-sourcekit-lsp command because I thought that we weren’t running sourcekit-lsp tests on the swift-syntax PR testing job (#72030). Then the job started failing with a TSAN failure and I thought that we would now not run sourcekit-lsp tests on the sourcekit-lsp PR testing job, so I added it there as well. Turns out that my first assumption that we weren’t running sourcekit-lsp tests on swift-syntax PRs was wrong and the downstream failure of that was just due to racing PRs. Furthermore, the `test-sourcekit-lsp` flag doesn’t even exist. Instead, it got typo-corrected (?) to `test-sourcekit-lsp-sanitize-all`, which enabled the TSAN sanitizer on the swift-syntax and sourcekit-lsp PR testing jobs. And that caused test failures. So, remove the `test-sourcekit-lsp` arguments again. After I made sourcekit-lsp build with strict concurrency / Swift 6 mode, I’ll re-enable TSAN on the sourcekit-lsp PR tests and fix any remaining TSAN issues.
1 parent 857a6c3 commit e6b7808

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

utils/build-presets.ini

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1878,7 +1878,6 @@ swiftsyntax-lint
18781878
swiftformat
18791879
skstresstester
18801880
sourcekit-lsp
1881-
test-sourcekit-lsp
18821881
install-swiftformat
18831882
skip-test-swift=false
18841883

@@ -1935,7 +1934,6 @@ mixin-preset=mixin_swiftpm_package_macos_platform
19351934
release
19361935
assertions
19371936
sourcekit-lsp
1938-
test-sourcekit-lsp
19391937
swiftformat
19401938
install-swiftformat
19411939
sourcekit-lsp-lint

0 commit comments

Comments
 (0)