Skip to content

Commit e8a9286

Browse files
authored
Merge pull request #84307 from tshortli/revert-require-swift-version-in-module-interfaces
Frontend: Temporarily downgrade `error_module_interface_requires_language_mode`
2 parents 01873c9 + e2c8235 commit e8a9286

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/Frontend/CompilerInvocation.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,8 +1035,10 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
10351035
if (!isValid)
10361036
diagnoseSwiftVersion(vers, A, Args, Diags);
10371037
} else if (FrontendOpts.InputsAndOutputs.hasModuleInterfaceOutputPath()) {
1038-
Diags.diagnose({}, diag::error_module_interface_requires_language_mode);
1039-
HadError = true;
1038+
Diags.diagnose({}, diag::error_module_interface_requires_language_mode)
1039+
.limitBehavior(DiagnosticBehavior::Warning);
1040+
// FIXME: Make this an error again (rdar://145168219)
1041+
// HadError = true;
10401042
}
10411043

10421044
if (auto A = Args.getLastArg(OPT_package_description_version)) {

test/ModuleInterface/language_mode.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// RUN: %empty-directory(%t)
22

3-
// RUN: not %swift_frontend_plain -target %target-swift-5.1-abi-triple %s \
3+
// RUN: %swift_frontend_plain -target %target-swift-5.1-abi-triple %s \
44
// RUN: -enable-library-evolution -module-name Test \
55
// RUN: -emit-module-interface-path %t.swiftinterface \
66
// RUN: -emit-module -o /dev/null 2>&1 | %FileCheck %s
77

8-
// CHECK: <unknown>:0: error: emitting module interface files requires '-language-mode'
8+
// CHECK: <unknown>:0: warning: emitting module interface files requires '-language-mode'
99

1010
// RUN: %swift_frontend_plain -target %target-swift-5.1-abi-triple %s \
1111
// RUN: -enable-library-evolution -module-name Test \

0 commit comments

Comments
 (0)