Skip to content

Commit ea3914d

Browse files
committed
[cmake] Remove dead link directory.
This was added some time ago in case we want to build clang separate from llvm just like we do swift. We do not actually support that though. Currently, this just results in the main llvm binary directory being added for a second time to the link path (i.e. this work iw asted). Thus just remove the line but leave in a *NOTE* to deliver the message that this is where the clang link path in such a case would need to go.
1 parent fc4061f commit ea3914d

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

cmake/modules/SwiftSharedCMakeConfig.cmake

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -241,11 +241,9 @@ macro(swift_common_standalone_build_config product is_cross_compiling)
241241
include_directories(${INCLUDE_DIR})
242242
endforeach ()
243243

244-
link_directories(
245-
"${LLVM_LIBRARY_DIR}"
246-
# FIXME: if we want to support separate Clang builds and mix different
247-
# build configurations of Clang and Swift, this line should be adjusted.
248-
"${PATH_TO_CLANG_BUILD}/${CMAKE_CFG_INTDIR}/lib")
244+
# *NOTE* if we want to support separate Clang builds as well as separate LLVM
245+
# builds, the clang build directory needs to be added here.
246+
link_directories("${LLVM_LIBRARY_DIR}")
249247

250248
set(LIT_ARGS_DEFAULT "-sv")
251249
if(XCODE)

0 commit comments

Comments
 (0)