Merge pull request #73705 from hamishknight/skip-placeholder

[CS] Avoid creating placeholder var if skipping for completion

Author: hamishknight

lib/Sema/BuilderTransform.cpp

@@ -197,9 +197,6 @@ class ResultBuilderTransform
         return std::nullopt;
       }
 
-      // Allocate variable with a placeholder type
-      auto *resultVar = buildPlaceholderVar(stmt->getStartLoc(), newBody);
-
       if (ctx.CompletionCallback && stmt->getSourceRange().isValid() &&
           !containsIDEInspectionTarget(stmt->getSourceRange(), ctx.SourceMgr) &&
           !isa<GuardStmt>(stmt)) {
@@ -209,6 +206,9 @@ class ResultBuilderTransform
         return std::nullopt;
       }
 
+      // Allocate variable with a placeholder type
+      auto *resultVar = buildPlaceholderVar(stmt->getStartLoc(), newBody);
+
       auto result = visit(stmt, resultVar);
       if (!result)
         return UnsupportedElt(stmt);

validation-test/IDE/issues_fixed/rdar127838305.swift

@@ -0,0 +1,19 @@
+// RUN: %batch-code-completion
+
+@resultBuilder struct MyBuilder {
+  static func buildBlock(_ components: [Int]...) -> [Int]
+  static func buildFinalResult(_ component: [Int]) -> Int
+}
+
+func build(@MyBuilder itemsBuilder: () -> Int) {}
+
+func test() {
+  let modifiers = build {
+    for modifier in invalid {
+    }
+  }
+
+  modifiers.#^COMPLETE^#
+}
+
+// COMPLETE: Keyword[self]/CurrNominal:          self[#Void#]; name=self