SIL Analysis: Rename InvalidationKind::FunctionData to InvalidationKind::Effects

This invalidation kind is used when a compute-effects pass changes function effects.
Also, let optimization passes which don't change effects only invalidate the `FunctionBody` and not `Everything`.

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/PassManager/PassContext.swift

@@ -119,7 +119,7 @@ struct PassContext {
   }
 
   func modifyEffects(in function: Function, _ body: (inout FunctionEffects) -> ()) {
-    notifyFunctionDataChanged()
+    notifyEffectsChanged()
     function._modifyEffects(body)
   }
 
@@ -139,8 +139,8 @@ struct PassContext {
     PassContext_notifyChanges(_bridged, branchesChanged)
   }
 
-  fileprivate func notifyFunctionDataChanged() {
-    PassContext_notifyChanges(_bridged, functionDataChanged)
+  fileprivate func notifyEffectsChanged() {
+    PassContext_notifyChanges(_bridged, effectsChanged)
   }
 }
 
@@ -243,7 +243,7 @@ extension RefCountingInst {
 
 extension Function {
   func set(needStackProtection: Bool, _ context: PassContext) {
-    context.notifyFunctionDataChanged()
+    context.notifyEffectsChanged()
     SILFunction_setNeedStackProtection(bridged, needStackProtection ? 1 : 0)
   }
 }

include/swift/SIL/SILBridging.h

@@ -34,7 +34,7 @@ enum ChangeNotificationKind {
   instructionsChanged,
   callsChanged,
   branchesChanged,
-  functionDataChanged
+  effectsChanged
 };
 
 typedef struct {

include/swift/SILOptimizer/Analysis/Analysis.h

@@ -64,11 +64,10 @@ class SILAnalysis {
     /// has been modified.
     Branches = 0x4,
 
-    /// Any function data other than its body.
+    /// The function effects.
     ///
-    /// It does not trigger any analysis invalidation, but tells the pass
-    /// manager that some changes were made.
-    FunctionData = 0x8,
+    /// The computed effects of the function are invalidated.
+    Effects = 0x8,
 
     /// Convenience states:
     FunctionBody = Calls | Branches | Instructions,
@@ -77,7 +76,7 @@ class SILAnalysis {
 
     BranchesAndInstructions = Branches | Instructions,
 
-    Everything = Calls | Branches | Instructions | FunctionData,
+    Everything = FunctionBody | Effects,
   };
 
 private:

include/swift/SILOptimizer/Analysis/DifferentiableActivityAnalysis.h

@@ -83,7 +83,7 @@ class DifferentiableActivityAnalysis
   }
 
   virtual bool shouldInvalidate(SILAnalysis::InvalidationKind k) override {
-    return k & InvalidationKind::Everything;
+    return k & InvalidationKind::FunctionBody;
   }
 
   virtual std::unique_ptr<DifferentiableActivityCollection>

lib/SILOptimizer/FunctionSignatureTransforms/ExistentialSpecializer.cpp

@@ -345,7 +345,7 @@ void ExistentialSpecializer::specializeExistentialArgsInAppliesWithinFunction(
 
         /// Invalidate analysis results of Callee.
         PM->invalidateAnalysis(Callee,
-                               SILAnalysis::InvalidationKind::Everything);
+                               SILAnalysis::InvalidationKind::FunctionBody);
       }
     }
   }

lib/SILOptimizer/FunctionSignatureTransforms/FunctionSignatureOpts.cpp

@@ -881,7 +881,7 @@ class FunctionSignatureOpts : public SILFunctionTransform {
     // The old function must be a thunk now.
     assert(F->isThunk() && "Old function should have been turned into a thunk");
 
-    invalidateAnalysis(SILAnalysis::InvalidationKind::Everything);
+    invalidateAnalysis(SILAnalysis::InvalidationKind::FunctionBody);
 
     // Make sure the PM knows about this function. This will also help us
     // with self-recursion.

lib/SILOptimizer/IPO/CapturePropagation.cpp

@@ -616,7 +616,7 @@ void CapturePropagation::run() {
     }
   }
   if (HasChanged) {
-    invalidateAnalysis(SILAnalysis::InvalidationKind::Everything);
+    invalidateAnalysis(SILAnalysis::InvalidationKind::FunctionBody);
   }
 }
 

lib/SILOptimizer/IPO/ClosureSpecializer.cpp

@@ -1003,7 +1003,7 @@ void SILClosureSpecializerTransform::run() {
 
   // Invalidate everything since we delete calls as well as add new
   // calls and branches.
-  invalidateAnalysis(SILAnalysis::InvalidationKind::Everything);
+  invalidateAnalysis(SILAnalysis::InvalidationKind::FunctionBody);
 }
 
 static void markReabstractionPartialApplyAsUsed(

lib/SILOptimizer/IPO/UsePrespecialized.cpp

@@ -47,7 +47,7 @@ class UsePrespecialized: public SILModuleTransform {
     auto &M = *getModule();
     for (auto &F : M) {
       if (replaceByPrespecialized(F)) {
-        invalidateAnalysis(&F, SILAnalysis::InvalidationKind::Everything);
+        invalidateAnalysis(&F, SILAnalysis::InvalidationKind::FunctionBody);
       }
     }
   }

lib/SILOptimizer/Mandatory/CapturePromotion.cpp

@@ -1649,7 +1649,7 @@ void CapturePromotionPass::processFunction(
         processPartialApplyInst(funcBuilder, pai, indicesPair.second, worklist);
     (void)clonedFn;
   }
-  invalidateAnalysis(func, SILAnalysis::InvalidationKind::Everything);
+  invalidateAnalysis(func, SILAnalysis::InvalidationKind::FunctionBody);
 }
 
 SILTransform *swift::createCapturePromotion() {