Cache the Identifier for "_ObjectiveCType". NFC.

Author: jrose-apple

include/swift/AST/KnownIdentifiers.def

@@ -51,6 +51,7 @@ IDENTIFIER_(nsErrorDomain)
 IDENTIFIER(objectAtIndexedSubscript)
 IDENTIFIER(objectForKeyedSubscript)
 IDENTIFIER(ObjectiveC)
+IDENTIFIER_(ObjectiveCType)
 IDENTIFIER_(OptionalNilComparisonType)
 IDENTIFIER(parameter)
 IDENTIFIER(Protocol)

lib/AST/ASTContext.cpp

@@ -3987,9 +3987,9 @@ ASTContext::getBridgedToObjC(const DeclContext *dc, Type type,
 
   // Find the type we bridge to.
   return ProtocolConformance::getTypeWitnessByName(type,
-                                               conformance->getConcrete(),
-                                               getIdentifier("_ObjectiveCType"),
-                                               resolver);
+                                                   conformance->getConcrete(),
+                                                   Id_ObjectiveCType,
+                                                   resolver);
 }
 
 std::pair<ArchetypeBuilder *, ArchetypeBuilder::PotentialArchetype *>

lib/PrintAsObjC/PrintAsObjC.cpp

@@ -807,7 +807,7 @@ class ObjCPrinter : private DeclVisitor<ObjCPrinter>,
     Type objcType = ProtocolConformance::getTypeWitnessByName(
                       nominal->getDeclaredType(),
                       conformance,
-                      ctx.getIdentifier("_ObjectiveCType"),
+                      ctx.Id_ObjectiveCType,
                       nullptr);
     if (!objcType) return false;
 

lib/SIL/Bridging.cpp

@@ -216,7 +216,7 @@ Type TypeConverter::getLoweredCBridgedType(AbstractionPattern pattern,
     assert(conformance && "Missing conformance?");
     Type bridgedTy =
       ProtocolConformance::getTypeWitnessByName(
-        t, conformance, M.getASTContext().getIdentifier("_ObjectiveCType"),
+        t, conformance, M.getASTContext().Id_ObjectiveCType,
         nullptr);
     assert(bridgedTy && "Missing _ObjectiveCType witness?");
     if (bridgedCollectionsAreOptional && clangTy)

lib/SILGen/SILGen.cpp

@@ -241,7 +241,7 @@ SILGenModule::getBridgedObjectiveCTypeRequirement(SILLocation loc) {
   // Look for _bridgeToObjectiveC().
   auto &ctx = getASTContext();
   AssociatedTypeDecl *found = nullptr;
-  DeclName name(ctx.getIdentifier("_ObjectiveCType"));
+  DeclName name(ctx.Id_ObjectiveCType);
   for (auto member : proto->lookupDirect(name, true)) {
     if (auto assocType = dyn_cast<AssociatedTypeDecl>(member)) {
       found = assocType;

lib/Sema/CSApply.cpp

@@ -1422,7 +1422,7 @@ namespace {
 
       // Add substitution for the dependent type T._ObjectiveCType.
       if (conformsToBridgedToObjectiveC) {
-        auto objcTypeId = tc.Context.getIdentifier("_ObjectiveCType");
+        auto objcTypeId = tc.Context.Id_ObjectiveCType;
         auto objcAssocType = cast<AssociatedTypeDecl>(
                                conformance->getProtocol()->lookupDirect(
                                  objcTypeId).front());