Skip to content

Commit f04e96c

Browse files
authored
Merge pull request #79328 from jeffdav/relax-stl-mismatch-conditions
util: Relax conditions on defining _ALLOW_COMPILER_AND_STL_VERSION_MI…
2 parents 9a7c9da + 87a1f38 commit f04e96c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

utils/build.ps1

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1650,11 +1650,13 @@ function Build-Compilers() {
16501650
$PythonRoot = "$BinaryCache\Python$($Arch.CMakeName)-$PythonVersion\tools"
16511651
$PythonLibName = "python{0}{1}" -f ([System.Version]$PythonVersion).Major, ([System.Version]$PythonVersion).Minor
16521652

1653-
# The STL in VS 17.10 requires Clang 17 or higher, but Swift toolchains prior to version 6 include older versions
1654-
# of Clang. If bootstrapping with an older toolchain, we need to relax to relax this requirement with
1655-
# ALLOW_COMPILER_AND_STL_VERSION_MISMATCH.
1653+
# The STL in the latest versions of VS typically require a newer version of
1654+
# Clang than released Swift toolchains include. If bootstrapping with an
1655+
# older toolchain, we need to relax this requirement by defining
1656+
# _ALLOW_COMPILER_AND_STL_VERSION_MISMATCH. Developer builds are (currently)
1657+
# up-to-date.
16561658
$SwiftFlags = @();
1657-
if ([System.Version](Get-PinnedToolchainVersion) -lt [System.Version]"6.0" -and [System.Version](Get-PinnedToolchainVersion) -ne [System.Version]"0.0.0") {
1659+
if ([System.Version](Get-PinnedToolchainVersion) -ne [System.Version]"0.0.0") {
16581660
$SwiftFlags += @("-Xcc", "-D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH");
16591661
}
16601662

0 commit comments

Comments
 (0)