[Serialization] Don't fatalError earlier than we have to

DougGregor · DougGregor · commit f318cf328d36 · 2025-09-10T16:43:15.000-07:00
Noticed as part of rdar://160278232.
diff --git a/lib/Serialization/Deserialization.cpp b/lib/Serialization/Deserialization.cpp
@@ -1724,7 +1724,7 @@ ModuleFile::getGenericSignatureChecked(serialization::GenericSignatureID ID) {
   }
   default:
     // Not a generic signature; no way to recover.
-    fatal(llvm::make_error<InvalidRecordKindError>(recordID));
+    return diagnoseFatal(llvm::make_error<InvalidRecordKindError>(recordID));
   }
 
   // If we've already deserialized this generic signature, start over to return

Original file line number	Diff line number	Diff line change
`@@ -1724,7 +1724,7 @@ ModuleFile::getGenericSignatureChecked(serialization::GenericSignatureID ID) {`
`1724`	`1724`	`}`
`1725`	`1725`	`default:`
`1726`	`1726`	`// Not a generic signature; no way to recover.`
`1727`		`- fatal(llvm::make_error<InvalidRecordKindError>(recordID));`
	`1727`	`+ return diagnoseFatal(llvm::make_error<InvalidRecordKindError>(recordID));`
`1728`	`1728`	`}`
`1729`	`1729`
`1730`	`1730`	`// If we've already deserialized this generic signature, start over to return`