Drop unused MemberRefExpr handling in LegalConstExprVerifier, adjust tests

Author: kubamracek

lib/Sema/LegalConstExprVerifier.cpp

@@ -237,19 +237,6 @@ checkSupportedWithSectionAttribute(const Expr *expr,
       return std::make_pair(expr, OpaqueDeclRef);
     }
 
-    // Member references for function names are allowed if non-generic
-    if (const MemberRefExpr *memberRef = dyn_cast<MemberRefExpr>(expr)) {
-      if (auto *funcDecl =
-              dyn_cast<FuncDecl>(memberRef->getMember().getDecl())) {
-        if (!funcDecl->isGeneric() &&
-            !funcDecl->getDeclContext()->isGenericContext()) {
-          continue;
-        }
-        return std::make_pair(expr, OpaqueFuncDeclRef);
-      }
-      return std::make_pair(expr, OpaqueDeclRef);
-    }
-
     // DotSelfExpr for metatype references (but only a direct TypeExpr inside)
     if (const DotSelfExpr *dotSelfExpr = dyn_cast<DotSelfExpr>(expr)) {
       if (const TypeExpr *typeExpr =

test/ConstValues/SectionSyntactic.swift

@@ -21,6 +21,9 @@
 @section("mysection") let boolLiteral1 = true // ok
 @section("mysection") let boolLiteral2 = false // ok
 
+// magic literals
+@section("mysection") let invalidNonLiteral4 = #line
+
 // operators (should be rejected)
 @section("mysection") let invalidOperator1 = 1 + 1
 // expected-error@-1{{unsupported operator in a '@const' expression}}
@@ -31,9 +34,11 @@
 
 // non-literal expressions (should be rejected)
 @section("mysection") let invalidNonLiteral1 = Int.max
-// expected-error@-1{{unable to resolve variable reference in a '@const' expression}}
+// expected-error@-1{{not supported in a '@const' expression}}
 @section("mysection") let invalidNonLiteral2 = UInt8(42)
 // expected-error@-1{{not supported in a '@const' expression}}
+@section("mysection") let invalidNonLiteral3 = true.hashValue
+// expected-error@-1{{not supported in a '@const' expression}}
 
 func foo() -> Int { return 42 }
 func bar(x: Int) -> String { return "test" }
@@ -83,7 +88,7 @@ enum E { case a }
 
 // invalid tuples (should be rejected)
 @section("mysection") let invalidTuple1 = (1, 2, Int.max)
-// expected-error@-1{{unable to resolve variable reference in a '@const' expression}}
+// expected-error@-1{{not supported in a '@const' expression}}
 @section("mysection") let invalidTuple2 = (1 + 1, 2)
 // expected-error@-1{{unsupported operator in a '@const' expression}}
 
@@ -120,7 +125,7 @@ struct MyCustomExpressibleByIntegerLiteral: ExpressibleByIntegerLiteral {
 // invalid inline array (should be rejected)
 @available(SwiftStdlib 6.2, *)
 @section("mysection") let invalidInlineArray: InlineArray = [1, 2, 3, Int.max]
-// expected-error@-1{{unable to resolve variable reference in a '@const' expression}}
+// expected-error@-1{{not supported in a '@const' expression}}
 
 // optionals (should be rejected)
 @section("mysection") let optional1: Int? = 42