Merge pull request #71727 from hborla/double-preconcurrency

[Concurrency] Don't add redundant implicit `@preconcurrency` attributes.

Author: hborla

lib/Sema/TypeCheckConcurrency.cpp

@@ -5009,7 +5009,8 @@ ActorIsolation ActorIsolationRequest::evaluate(
             CustomAttr::create(ctx, SourceLoc(), typeExpr, /*implicit=*/true);
         value->getAttrs().add(attr);
 
-        if (inferred.preconcurrency()) {
+        if (inferred.preconcurrency() &&
+            !value->getAttrs().hasAttribute<PreconcurrencyAttr>()) {
           auto preconcurrency =
               new (ctx) PreconcurrencyAttr(/*isImplicit*/true);
           value->getAttrs().add(preconcurrency);

test/ModuleInterface/concurrency.swift

@@ -32,6 +32,7 @@ public protocol UnsafeMainProtocol {
 
 public struct InferredUnsafeMainActor: UnsafeMainProtocol {
   public func requirement() {}
+  @preconcurrency public func explicitPreconcurrency() {}
 }
 
 @preconcurrency @MainActor
@@ -41,6 +42,7 @@ public protocol PreconcurrencyMainProtocol {
 
 public struct InferredPreconcurrencyMainActor: PreconcurrencyMainProtocol {
   public func requirement() {}
+  @preconcurrency public func explicitPreconcurrency() {}
 }
 
 // rdar://122965951
@@ -71,6 +73,7 @@ func callFn() async {
 
 // CHECK:      @_Concurrency.MainActor @preconcurrency public struct InferredUnsafeMainActor :
 // CHECK-NEXT:   @_Concurrency.MainActor @preconcurrency public func requirement()
+// CHECK-NEXT:   @preconcurrency @_Concurrency.MainActor public func explicitPreconcurrency()
 // CHECK-NEXT: }
 
 // CHECK:      @preconcurrency @_Concurrency.MainActor public protocol PreconcurrencyMainProtocol {
@@ -79,6 +82,7 @@ func callFn() async {
 
 // CHECK:      @_Concurrency.MainActor @preconcurrency public struct InferredPreconcurrencyMainActor :
 // CHECK-NEXT:   @_Concurrency.MainActor @preconcurrency public func requirement()
+// CHECK-NEXT:   @preconcurrency @_Concurrency.MainActor public func explicitPreconcurrency()
 // CHECK-NEXT: }
 
 // CHECK-TYPECHECKED: public struct UncheckedSendable : @unchecked Swift.Sendable